You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/10/29 09:01:55 UTC

[GitHub] [incubator-linkis] lunescode opened a new pull request #1054: bugFix:instance Label Parase failed when hostname contains serciename.

lunescode opened a new pull request #1054:
URL: https://github.com/apache/incubator-linkis/pull/1054


   ### What is the purpose of the change
   bugFix:instance Label Parase failed when hostname contains serciename.
   for example,
   hostname: linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local
   serviceName:linkis-cg-engineconnmanager
   str:linkis-cg-engineconnmanager-linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local:9104
   after setStringValue:
   instance = -0.linkis-svc.default.svc.cluster.local:9104
   correct value should be: linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local:9104
   
   ### Brief change log
   - replace replace with replaceFirst in EMInstanceLabel.java and EngineInstanceLabel.java 
   
   ### Verifying this change
   (Please pick either of the following options)  
   This change is a trivial rework / code cleanup without any test coverage.  
   
   ### Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): (no)
   - Anything that affects deployment: ( no )
   - The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
   
   ### Documentation
   - Does this pull request introduce a new feature? ( no)
   - If yes, how is the feature documented? (not applicable)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong merged pull request #1054: bugFix:instance Label parase failed when hostname contains servicename.

Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1054:
URL: https://github.com/apache/incubator-linkis/pull/1054


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org