You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Daniel Leffel (JIRA)" <ji...@apache.org> on 2009/05/14 11:30:45 UTC
[jira] Created: (HADOOP-5833)
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output
Format Class to SequenceFileOutputFormat
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
---------------------------------------------------------------------------------------------------------------
Key: HADOOP-5833
URL: https://issues.apache.org/jira/browse/HADOOP-5833
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Affects Versions: 0.20.0
Reporter: Daniel Leffel
Priority: Minor
The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5833)
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output
Format Class to SequenceFileOutputFormat
Posted by "Daniel Leffel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Leffel updated HADOOP-5833:
----------------------------------
Status: Patch Available (was: Open)
> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5833
> URL: https://issues.apache.org/jira/browse/HADOOP-5833
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Daniel Leffel
> Priority: Minor
> Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5833)
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output
Format Class to SequenceFileOutputFormat
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal resolved HADOOP-5833.
------------------------------------
Resolution: Invalid
setOutputPath should not set the output format class. Its better if users set that explicitly. Resolving this issue. Please reopen if anyone thinks otherwise.
> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5833
> URL: https://issues.apache.org/jira/browse/HADOOP-5833
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Daniel Leffel
> Priority: Minor
> Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5833)
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output
Format Class to SequenceFileOutputFormat
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5833:
-----------------------------------
Status: Open (was: Patch Available)
> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5833
> URL: https://issues.apache.org/jira/browse/HADOOP-5833
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Daniel Leffel
> Priority: Minor
> Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5833)
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output
Format Class to SequenceFileOutputFormat
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709655#action_12709655 ]
Hadoop QA commented on HADOOP-5833:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408122/hadoop-5833.patch
against trunk revision 774912.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs to fail.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/342/testReport/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/342/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/342/console
This message is automatically generated.
> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5833
> URL: https://issues.apache.org/jira/browse/HADOOP-5833
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Daniel Leffel
> Priority: Minor
> Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5833)
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output
Format Class to SequenceFileOutputFormat
Posted by "Daniel Leffel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Leffel updated HADOOP-5833:
----------------------------------
Attachment: hadoop-5833.patch
> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5833
> URL: https://issues.apache.org/jira/browse/HADOOP-5833
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Daniel Leffel
> Priority: Minor
> Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5833)
SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output
Format Class to SequenceFileOutputFormat
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717944#action_12717944 ]
Sharad Agarwal commented on HADOOP-5833:
----------------------------------------
The current patch does not compile as it references the super from a static method.
Also, OutputFormat.setOutputPath is a static method and it sets the output path on the job configuration as expected. The child classes don't need to override this functionality.
> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5833
> URL: https://issues.apache.org/jira/browse/HADOOP-5833
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Daniel Leffel
> Priority: Minor
> Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.