You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jaikiran Pai <ja...@gmail.com> on 2015/01/09 08:50:09 UTC
Review Request 29756: Patch for KAFKA-1854
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1854
https://issues.apache.org/jira/browse/KAFKA-1854
Repository: kafka
Description
-------
KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
Diffs
-----
kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
Diff: https://reviews.apache.org/r/29756/diff/
Testing
-------
Thanks,
Jaikiran Pai
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 9:44 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 134
> > <https://reviews.apache.org/r/29756/diff/2/?file=814144#file814144line134>
> >
> > Can we do authentication check at the beginning and fail-fast if the username/password is wrong. Currently it will update the review-board and fails at JIRA update.
> >
> > Is it possible to catch the exception/error, and show the message "Invalid JIRA username/password"
I've updated the patch to verify the JIRA login before publishing/updating the reviewboard. If the JIRA login fails, the patch submission tool now prints out the inability to login to JIRA and exits the tool.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67400
-----------------------------------------------------------
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67400
-----------------------------------------------------------
kafka-patch-review.py
<https://reviews.apache.org/r/29756/#comment111418>
Can we do authentication check at the beginning and fail-fast if the username/password is wrong. Currently it will update the review-board and fails at JIRA update.
Is it possible to catch the exception/error, and show the message "Invalid JIRA username/password"
- Manikumar Reddy O
On Jan. 9, 2015, 8:09 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 8:09 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Manikumar Reddy O <ma...@gmail.com>.
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
>
> Jaikiran Pai wrote:
> I did test a failure case, yes. Gave an incorrect username and password and that failed during login and did not proceed further. Here's the relevant output (notice that I intentionally use JIRA user name "foo"):
>
> `
>
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> HTTP 401: "
>
> <html>
>
> <head>
> <title>Unauthorized (401)</title>
>
> ....
> `
>
> Jaikiran Pai wrote:
> By the way, if you are testing this, make sure you don't have a jira.ini in its usual place. Else the (correct) credentials in there will be used as usual and you won't be able to replicate a failing scenario.
>
> Manikumar Reddy O wrote:
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Creating diff against origin/0.8.2 and uploading patch to JIRA KAFKA-1723
>
>
> I am not getting exception, it going to next line of execution. It is failing at jira.issue().
>
> Version : jira-python 0.16
>
> Jaikiran Pai wrote:
> That's interesting. Let me see what might be different.
>
> Jaikiran Pai wrote:
> Turns out the version of jira python that I had was 0.31 and behaved differently. I downgraded to 0.16 and was able to replicate what you are seeing. I've updated the patch to fix this and it should now correctly fail if wrong JIRA credentials are specified, even before it attempts to publish to reviewboard.
>
> Let me know if this now works for you too. Thanks for testing this!
Latest patch is working with jira-python 0.16. Some members may be using older versions. We need to find correct API which works across all the
jira-python versions. (or) we need to add minimum version requirement.
- Manikumar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 12:47 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
>
> Jaikiran Pai wrote:
> I did test a failure case, yes. Gave an incorrect username and password and that failed during login and did not proceed further. Here's the relevant output (notice that I intentionally use JIRA user name "foo"):
>
> `
>
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> HTTP 401: "
>
> <html>
>
> <head>
> <title>Unauthorized (401)</title>
>
> ....
> `
>
> Jaikiran Pai wrote:
> By the way, if you are testing this, make sure you don't have a jira.ini in its usual place. Else the (correct) credentials in there will be used as usual and you won't be able to replicate a failing scenario.
>
> Manikumar Reddy O wrote:
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Creating diff against origin/0.8.2 and uploading patch to JIRA KAFKA-1723
>
>
> I am not getting exception, it going to next line of execution. It is failing at jira.issue().
>
> Version : jira-python 0.16
>
> Jaikiran Pai wrote:
> That's interesting. Let me see what might be different.
Turns out the version of jira python that I had was 0.31 and behaved differently. I downgraded to 0.16 and was able to replicate what you are seeing. I've updated the patch to fix this and it should now correctly fail if wrong JIRA credentials are specified, even before it attempts to publish to reviewboard.
Let me know if this now works for you too. Thanks for testing this!
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 12:47 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
>
> Jaikiran Pai wrote:
> I did test a failure case, yes. Gave an incorrect username and password and that failed during login and did not proceed further. Here's the relevant output (notice that I intentionally use JIRA user name "foo"):
>
> `
>
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> HTTP 401: "
>
> <html>
>
> <head>
> <title>Unauthorized (401)</title>
>
> ....
> `
>
> Jaikiran Pai wrote:
> By the way, if you are testing this, make sure you don't have a jira.ini in its usual place. Else the (correct) credentials in there will be used as usual and you won't be able to replicate a failing scenario.
>
> Manikumar Reddy O wrote:
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Creating diff against origin/0.8.2 and uploading patch to JIRA KAFKA-1723
>
>
> I am not getting exception, it going to next line of execution. It is failing at jira.issue().
>
> Version : jira-python 0.16
That's interesting. Let me see what might be different.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Manikumar Reddy O <ma...@gmail.com>.
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
>
> Jaikiran Pai wrote:
> I did test a failure case, yes. Gave an incorrect username and password and that failed during login and did not proceed further. Here's the relevant output (notice that I intentionally use JIRA user name "foo"):
>
> `
>
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> HTTP 401: "
>
> <html>
>
> <head>
> <title>Unauthorized (401)</title>
>
> ....
> `
>
> Jaikiran Pai wrote:
> By the way, if you are testing this, make sure you don't have a jira.ini in its usual place. Else the (correct) credentials in there will be used as usual and you won't be able to replicate a failing scenario.
Configuring reviewboard url to https://reviews.apache.org
Updating your remote branches to pull the latest changes
Verifying JIRA connection configurations
JIRA user :foo
JIRA password :
Creating diff against origin/0.8.2 and uploading patch to JIRA KAFKA-1723
I am not getting exception, it going to next line of execution. It is failing at jira.issue().
Version : jira-python 0.16
- Manikumar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
>
> Jaikiran Pai wrote:
> I did test a failure case, yes. Gave an incorrect username and password and that failed during login and did not proceed further. Here's the relevant output (notice that I intentionally use JIRA user name "foo"):
>
> `
>
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> HTTP 401: "
>
> <html>
>
> <head>
> <title>Unauthorized (401)</title>
>
> ....
> `
>
> Jaikiran Pai wrote:
> By the way, if you are testing this, make sure you don't have a jira.ini in its usual place. Else the (correct) credentials in there will be used as usual and you won't be able to replicate a failing scenario.
>
> Manikumar Reddy O wrote:
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Creating diff against origin/0.8.2 and uploading patch to JIRA KAFKA-1723
>
>
> I am not getting exception, it going to next line of execution. It is failing at jira.issue().
>
> Version : jira-python 0.16
>
> Jaikiran Pai wrote:
> That's interesting. Let me see what might be different.
>
> Jaikiran Pai wrote:
> Turns out the version of jira python that I had was 0.31 and behaved differently. I downgraded to 0.16 and was able to replicate what you are seeing. I've updated the patch to fix this and it should now correctly fail if wrong JIRA credentials are specified, even before it attempts to publish to reviewboard.
>
> Let me know if this now works for you too. Thanks for testing this!
>
> Manikumar Reddy O wrote:
> Latest patch is working with jira-python 0.16. Some members may be using older versions. We need to find correct API which works across all the
> jira-python versions. (or) we need to add minimum version requirement.
Thank you Manikumar for testing and verifying. I'll see what can be done about the jira-python version issues.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 12:47 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
I did test a failure case, yes. Gave an incorrect username and password and that failed during login and did not proceed further. Here's the relevant output (notice that I intentionally use JIRA user name "foo"):
`
Configuring reviewboard url to https://reviews.apache.org
Updating your remote branches to pull the latest changes
Verifying JIRA connection configurations
JIRA user :foo
JIRA password :
Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> HTTP 401: "
<html>
<head>
<title>Unauthorized (401)</title>
....
`
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
>
> Jaikiran Pai wrote:
> I did test a failure case, yes. Gave an incorrect username and password and that failed during login and did not proceed further. Here's the relevant output (notice that I intentionally use JIRA user name "foo"):
>
> `
>
> Configuring reviewboard url to https://reviews.apache.org
> Updating your remote branches to pull the latest changes
> Verifying JIRA connection configurations
> JIRA user :foo
> JIRA password :
> Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> HTTP 401: "
>
> <html>
>
> <head>
> <title>Unauthorized (401)</title>
>
> ....
> `
By the way, if you are testing this, make sure you don't have a jira.ini in its usual place. Else the (correct) credentials in there will be used as usual and you won't be able to replicate a failing scenario.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
-----------------------------------------------------------
kafka-patch-review.py
<https://reviews.apache.org/r/29756/#comment111442>
Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue().
- Manikumar Reddy O
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAKFA-1854
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67884
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Jan. 13, 2015, 5:43 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 5:43 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAKFA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 5:43 a.m.)
Review request for kafka.
Changes
-------
Fixed typo in JIRA id
Bugs: KAFKA-1854
https://issues.apache.org/jira/browse/KAFKA-1854
Repository: kafka
Description
-------
KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
Diffs
-----
kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
Diff: https://reviews.apache.org/r/29756/diff/
Testing
-------
Thanks,
Jaikiran Pai
Re: Review Request 29756: Patch for KAKFA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 5:42 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAKFA-1854
Bugs: KAFKA-1854 and KAKFA-1854
https://issues.apache.org/jira/browse/KAFKA-1854
https://issues.apache.org/jira/browse/KAKFA-1854
Repository: kafka
Description
-------
KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
Diffs (updated)
-----
kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
Diff: https://reviews.apache.org/r/29756/diff/
Testing
-------
Thanks,
Jaikiran Pai
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote:
> > kafka-patch-review.py, line 20
> > <https://reviews.apache.org/r/29756/diff/4/?file=814310#file814310line20>
> >
> > I got the following error on this patch
> >
> > nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b trunk -j KAFKA-1854 -d test
> > Configuring reviewboard url to https://reviews.apache.org
> > Updating your remote branches to pull the latest changes
> > Verifying JIRA connection configurations
> > JIRA user :nehanarkhede
> > JIRA password :
> > Failed to login to the JIRA instance <type 'exceptions.AttributeError'> 'JIRA' object has no attribute 'current_user'
> >
> > Maybe a different version of the jira package we use renamed the user field ?
Neha, which version of jira-python are you using? I'll find and check that project's documentation to see which version supports what.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67477
-----------------------------------------------------------
On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 12:47 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAKFA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote:
> > kafka-patch-review.py, line 20
> > <https://reviews.apache.org/r/29756/diff/4/?file=814310#file814310line20>
> >
> > I got the following error on this patch
> >
> > nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b trunk -j KAFKA-1854 -d test
> > Configuring reviewboard url to https://reviews.apache.org
> > Updating your remote branches to pull the latest changes
> > Verifying JIRA connection configurations
> > JIRA user :nehanarkhede
> > JIRA password :
> > Failed to login to the JIRA instance <type 'exceptions.AttributeError'> 'JIRA' object has no attribute 'current_user'
> >
> > Maybe a different version of the jira package we use renamed the user field ?
>
> Jaikiran Pai wrote:
> Neha, which version of jira-python are you using? I'll find and check that project's documentation to see which version supports what.
>
> Neha Narkhede wrote:
> I'm not entirely sure. What's the best way to find out?
>
> Neha Narkhede wrote:
> In any case, I think the tool should be robust enough to deal with this issue.
Hi Neha,
For knowing the jira-python (or any other python library installation), one way is to run the following command:
`pip show jira-python`
The jira-python documentation is hard to find for each specific version (they just have the latest online). So I had to look at their source for each/most of the tagged versions to see which API was supported https://bitbucket.org/bspeakmon/jira-python/src. I have made a change to this patch which works and I think it should work even for lower and higher versions of that library (based on what I see in those tagged versions).
Could you please give this a try again and see how it goes for you? Thank you.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67477
-----------------------------------------------------------
On Jan. 13, 2015, 5:43 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 5:43 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Neha Narkhede <ne...@gmail.com>.
> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote:
> > kafka-patch-review.py, line 20
> > <https://reviews.apache.org/r/29756/diff/4/?file=814310#file814310line20>
> >
> > I got the following error on this patch
> >
> > nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b trunk -j KAFKA-1854 -d test
> > Configuring reviewboard url to https://reviews.apache.org
> > Updating your remote branches to pull the latest changes
> > Verifying JIRA connection configurations
> > JIRA user :nehanarkhede
> > JIRA password :
> > Failed to login to the JIRA instance <type 'exceptions.AttributeError'> 'JIRA' object has no attribute 'current_user'
> >
> > Maybe a different version of the jira package we use renamed the user field ?
>
> Jaikiran Pai wrote:
> Neha, which version of jira-python are you using? I'll find and check that project's documentation to see which version supports what.
>
> Neha Narkhede wrote:
> I'm not entirely sure. What's the best way to find out?
In any case, I think the tool should be robust enough to deal with this issue.
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67477
-----------------------------------------------------------
On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 12:47 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Neha Narkhede <ne...@gmail.com>.
> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote:
> > kafka-patch-review.py, line 20
> > <https://reviews.apache.org/r/29756/diff/4/?file=814310#file814310line20>
> >
> > I got the following error on this patch
> >
> > nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b trunk -j KAFKA-1854 -d test
> > Configuring reviewboard url to https://reviews.apache.org
> > Updating your remote branches to pull the latest changes
> > Verifying JIRA connection configurations
> > JIRA user :nehanarkhede
> > JIRA password :
> > Failed to login to the JIRA instance <type 'exceptions.AttributeError'> 'JIRA' object has no attribute 'current_user'
> >
> > Maybe a different version of the jira package we use renamed the user field ?
>
> Jaikiran Pai wrote:
> Neha, which version of jira-python are you using? I'll find and check that project's documentation to see which version supports what.
I'm not entirely sure. What's the best way to find out?
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67477
-----------------------------------------------------------
On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 12:47 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67477
-----------------------------------------------------------
kafka-patch-review.py
<https://reviews.apache.org/r/29756/#comment111521>
I got the following error on this patch
nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b trunk -j KAFKA-1854 -d test
Configuring reviewboard url to https://reviews.apache.org
Updating your remote branches to pull the latest changes
Verifying JIRA connection configurations
JIRA user :nehanarkhede
JIRA password :
Failed to login to the JIRA instance <type 'exceptions.AttributeError'> 'JIRA' object has no attribute 'current_user'
Maybe a different version of the jira package we use renamed the user field ?
- Neha Narkhede
On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 12:47 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 12:47 p.m.)
Review request for kafka.
Bugs: KAFKA-1854
https://issues.apache.org/jira/browse/KAFKA-1854
Repository: kafka
Description
-------
KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
Diffs (updated)
-----
kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
Diff: https://reviews.apache.org/r/29756/diff/
Testing
-------
Thanks,
Jaikiran Pai
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 10:13 a.m.)
Review request for kafka.
Bugs: KAFKA-1854
https://issues.apache.org/jira/browse/KAFKA-1854
Repository: kafka
Description
-------
KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
Diffs (updated)
-----
kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
Diff: https://reviews.apache.org/r/29756/diff/
Testing
-------
Thanks,
Jaikiran Pai
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 8:09 a.m.)
Review request for kafka.
Bugs: KAFKA-1854
https://issues.apache.org/jira/browse/KAFKA-1854
Repository: kafka
Description
-------
KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
Diffs (updated)
-----
kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
Diff: https://reviews.apache.org/r/29756/diff/
Testing
-------
Thanks,
Jaikiran Pai
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 9, 2015, 7:52 a.m., Jaikiran Pai wrote:
> > This one needs a minor change which I'm going to submit as an update
Patch updated and now ready for review.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67388
-----------------------------------------------------------
On Jan. 9, 2015, 8:09 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 8:09 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 29756: Patch for KAFKA-1854
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67388
-----------------------------------------------------------
This one needs a minor change which I'm going to submit as an update
- Jaikiran Pai
On Jan. 9, 2015, 7:50 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29756/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 7:50 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1854
> https://issues.apache.org/jira/browse/KAFKA-1854
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1854 Allow JIRA username and password to be prompted in the absence of a jira.ini file, during patch submission
>
>
> Diffs
> -----
>
> kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38
>
> Diff: https://reviews.apache.org/r/29756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaikiran Pai
>
>