[GitHub] [solr] markrmiller commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

[GitBox <gi...@apache.org>]

markrmiller commented on a change in pull request #322:
URL: https://github.com/apache/solr/pull/322#discussion_r719189790



##########
File path: solr/core/src/java/org/apache/solr/core/ZkContainer.java
##########
@@ -144,25 +139,6 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) {
           } else {
             UrlScheme.INSTANCE.setUrlScheme(System.getProperty(URL_SCHEME, HTTP));
           }
-
-          if (zkServer.getServers().size() > 1 && confDir == null && boostrapConf == false) {
-            // we are part of an ensemble and we are not uploading the config - pause to give the config time
-            // to get up
-            Thread.sleep(10000);

Review comment:
       Looks like very old behavior for embedded zookeeper mode when you had to preconfigure a collection before startup.
   
   I don't know the state of embedded zk, but I have a hard time imagining this makes any sense anymore. If it did, it's a terrible way to wait.
   
   I'm sure it did this because with a preconfigured collection, the cores coming up would need to find config or fail. Nothing works this way anymore. Default config is uploaded automatically. You start with 0 cores or collections. 
   
   Embedded zk was never part of any test as far as I know, but id assume this bootstrap stuff is irrelevant now. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org