[GitHub] [kafka] cmccabe commented on pull request #11593: KAFKA-13528: KRaft RegisterBroker should validate that the cluster ID matches

[GitBox <gi...@apache.org>]

cmccabe commented on pull request #11593:
URL: https://github.com/apache/kafka/pull/11593#issuecomment-991360698


   > What should be the broker behavior if cannot register because of an invalid cluster id? Looking at the current code it looks like the broker will continue to retry. InconsistentClusterIdException is not mark as retriable so I xxx  think the broker should just shutdown, no?
   
   If the broker can't perform its initial registration, it will eventually shut itself down. This behavior is not specific to `InconsistentClusterIdException` -- if the broker can't register for ANY reason, it will shut down eventually. The length of time it will retry is configured by `initial.broker.registration.timeout.ms`.
   
   I agree that maybe we could shut down more rapidly here, but it seems simpler just to rely on the standard timeout. I don't think this is a common enough scenario to need a special case optimization.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org