svn commit: r1546255 - in /tomee/tomee/trunk/container/openejb-core: pom.xml src/main/config/pmd/openejb-basic.xml

[tv...@apache.org]

Author: tveronezi
Date: Thu Nov 28 01:54:03 2013
New Revision: 1546255

URL: http://svn.apache.org/r1546255
Log:
pmd should complain before the tests

Modified:
    tomee/tomee/trunk/container/openejb-core/pom.xml
    tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-basic.xml

Modified: tomee/tomee/trunk/container/openejb-core/pom.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/pom.xml?rev=1546255&r1=1546254&r2=1546255&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/pom.xml (original)
+++ tomee/tomee/trunk/container/openejb-core/pom.xml Thu Nov 28 01:54:03 2013
@@ -266,6 +266,7 @@
         </configuration>
         <executions>
           <execution>
+            <phase>compile</phase>
             <goals>
               <goal>check</goal>
             </goals>

Modified: tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-basic.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-basic.xml?rev=1546255&r1=1546254&r2=1546255&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-basic.xml (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-basic.xml Thu Nov 28 01:54:03 2013
@@ -28,7 +28,6 @@
   <!-- All the rules from basic.xml -->
   <rule ref="rulesets/java/basic.xml">
     <exclude name="EmptyCatchBlock"/> <!-- This is covered by the openejb-empty.xml file -->
-    <exclude name="UselessOverridingMethod"/>
     <exclude name="CollapsibleIfStatements"/>
     <exclude name="ReturnFromFinallyBlock"/>
     <exclude name="AvoidBranchingStatementAsLastInLoop"/>