[jira] [Commented] (ARTEMIS-4160) jolokia-access.xml getting invalid XML from hostname during instance creation

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691927#comment-17691927 ] 

ASF subversion and git services commented on ARTEMIS-4160:
----------------------------------------------------------

Commit 7e1f6c1abe0f3586e06abd5f8a83c8fbf5357852 in activemq-artemis's branch refs/heads/main from David Lanouette
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7e1f6c1abe ]

ARTEMIS-4160 Handle hostnames with double dashes

Previously, the code added a comment with the host name in it.
Sometimes hostnames don't follow the xml standards for comments.
Specifically, having a double dash ("--") in the host name would cause
an error when jolokia tried to load the config file - because it was
invalid xml.

The simple solution was to not put the host name into the comment.

A unit test has been included to ensure the same thing doesn't happen in the
future.

Signed-off-by: David Lanouette <Da...@RedHat.com>


> jolokia-access.xml getting invalid XML from hostname during instance creation
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-4160
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4160
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Priority: Major
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)