You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/03 12:40:52 UTC
[GitHub] [camel-quarkus] apupier opened a new pull request, #3956: CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4
apupier opened a new pull request, #3956:
URL: https://github.com/apache/camel-quarkus/pull/3956
might worth merging at same time than https://github.com/apache/camel/pull/8102
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] apupier closed pull request #3956: CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier closed pull request #3956: CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4
URL: https://github.com/apache/camel-quarkus/pull/3956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] apupier commented on pull request #3956: CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4
Posted by GitBox <gi...@apache.org>.
apupier commented on PR #3956:
URL: https://github.com/apache/camel-quarkus/pull/3956#issuecomment-1203987911
I do not understand why it complains about uncommited files.
```
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: poms/bom/src/main/generated/flattened-full-pom.xml
modified: poms/bom/src/main/generated/flattened-reduced-pom.xml
modified: poms/bom/src/main/generated/flattened-reduced-verbose-pom.xml
```
the mentioned files have a lot of modifications. i tried to run the build locally again and I do not have other changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] apupier commented on pull request #3956: CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4
Posted by GitBox <gi...@apache.org>.
apupier commented on PR #3956:
URL: https://github.com/apache/camel-quarkus/pull/3956#issuecomment-1204992541
ah when i see the diff, i think it is because we need to merge first https://github.com/apache/camel/pull/8102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #3956: CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #3956:
URL: https://github.com/apache/camel-quarkus/pull/3956#issuecomment-1204863109
Attached a diff of the changes that I see when running the build.
Not sure what Maven version you are running, but try to run the build with the `mvnw` script if you have not already done so. That may help.
[diff.txt](https://github.com/apache/camel-quarkus/files/9257486/diff.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] apupier commented on pull request #3956: CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #3956:
URL: https://github.com/apache/camel-quarkus/pull/3956#issuecomment-1558733535
outdated.
Note that Camel Core has migrated to Apache groovy 4 https://github.com/apache/camel/pull/9487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org