[GitHub] [airflow] michaelmicheal commented on a diff in pull request #29407: Ensure Serialized DAG is deleted

["michaelmicheal (via GitHub)" <gi...@apache.org>]

michaelmicheal commented on code in PR #29407:
URL: https://github.com/apache/airflow/pull/29407#discussion_r1100230887


##########
airflow/dag_processing/manager.py:
##########
@@ -765,9 +765,13 @@ def _refresh_dag_dir(self):
                 else:
                     dag_filelocs.append(fileloc)
 
+            processor_subdir = None
+            if self.standalone_dag_processor:
+                processor_subdir = self.get_dag_directory()
+
             SerializedDagModel.remove_deleted_dags(
                 alive_dag_filelocs=dag_filelocs,
-                processor_subdir=self.get_dag_directory(),
+                processor_subdir=processor_subdir,

Review Comment:
   While that worked, I was misunderstanding the `remove_deleted_dags` method and found out it was a bug in that method. See latest commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org