You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/09 21:51:15 UTC
[GitHub] [spark] holdenk opened a new pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
holdenk opened a new pull request #30694:
URL: https://github.com/apache/spark/pull/30694
### What changes were proposed in this pull request?
Makes the location of the decommission script used in Kubernetes for graceful shutdown configurable.
### Why are the changes needed?
Some environments don't use the Spark image builder and instead mount the decompressed Spark distro. In those envs configuring the location of the decommissioning script is required.
### Does this PR introduce _any_ user-facing change?
New configuration parameter.
### How was this patch tested?
Existing decommissioning integration test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742233122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742224389
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132535/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742220154
**[Test build #132535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132535/testReport)** for PR 30694 at commit [`46ca366`](https://github.com/apache/spark/commit/46ca3664880532007248717f5c41847716e5aeb7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742116727
K8s IT fails with `gpg: keyserver receive failed: No name`. This seems to be consistent in the new Jenkins Server.
```
Executing: /tmp/apt-key-gpghome.gGqC9RwptN/gpg.1.sh --keyserver keys.gnupg.net --recv-key E19F5F87128899B192B1A2C2AD5F960A256A04AF
gpg: keyserver receive failed: No name
The command '/bin/sh -c echo "deb http://cloud.r-project.org/bin/linux/debian buster-cran35/" >> /etc/apt/sources.list && apt install -y gnupg && apt-key adv --keyserver keys.gnupg.net --recv-key 'E19F5F87128899B192B1A2C2AD5F960A256A04AF' && apt-get update && apt install -y -t buster-cran35 r-base r-base-dev && rm -rf /var/cache/apt/*' returned a non-zero code: 2
```
It locally works.
```
$ gpg1 --keyserver keys.gnupg.net --recv-key E19F5F87128899B192B1A2C2AD5F960A256A04AF
gpg: requesting key 256A04AF from hkp server keys.gnupg.net
gpg: key 256A04AF: public key "Johannes Ranke (Wissenschaftlicher Berater) <jo...@jrwb.de>" imported
gpg: 3 marginal(s) needed, 1 complete(s) needed, PGP trust model
gpg: depth: 0 valid: 2 signed: 1 trust: 0-, 0q, 0n, 0m, 0f, 2u
gpg: depth: 1 valid: 1 signed: 0 trust: 1-, 0q, 0n, 0m, 0f, 0u
gpg: Total number processed: 1
gpg: imported: 1 (RSA: 1)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742220154
**[Test build #132535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132535/testReport)** for PR 30694 at commit [`46ca366`](https://github.com/apache/spark/commit/46ca3664880532007248717f5c41847716e5aeb7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742091960
**[Test build #132517 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132517/testReport)** for PR 30694 at commit [`1df978c`](https://github.com/apache/spark/commit/1df978c6d7969e0c6d8520ee1f475ac92158b817).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742085713
**[Test build #132517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132517/testReport)** for PR 30694 at commit [`1df978c`](https://github.com/apache/spark/commit/1df978c6d7969e0c6d8520ee1f475ac92158b817).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742092138
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132517/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30694:
URL: https://github.com/apache/spark/pull/30694#discussion_r539781022
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -24,6 +24,14 @@ import org.apache.spark.internal.config.ConfigBuilder
private[spark] object Config extends Logging {
+ val DECOM_SCRIPT =
+ ConfigBuilder("spark.kubernetes.decom.script")
Review comment:
Maybe `decom` -> `decommission`? Looks like other decommission configuration names don't use such abbreviation .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742106616
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37120/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30694:
URL: https://github.com/apache/spark/pull/30694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742085713
**[Test build #132517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132517/testReport)** for PR 30694 at commit [`1df978c`](https://github.com/apache/spark/commit/1df978c6d7969e0c6d8520ee1f475ac92158b817).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742224277
**[Test build #132535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132535/testReport)** for PR 30694 at commit [`46ca366`](https://github.com/apache/spark/commit/46ca3664880532007248717f5c41847716e5aeb7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742235754
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37139/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742235754
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37139/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742119157
SPARK-33727 is filed for the K8s IT failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742092138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742143092
Thanks for filing the infra issue @dongjoon-hyun.
If no one objects I'll merge this on Friday while we work on the infra issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742224389
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132535/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742116727
K8s IT fails with `gpg: keyserver receive failed: No name`. This seems to be consistent.
```
Executing: /tmp/apt-key-gpghome.gGqC9RwptN/gpg.1.sh --keyserver keys.gnupg.net --recv-key E19F5F87128899B192B1A2C2AD5F960A256A04AF
gpg: keyserver receive failed: No name
The command '/bin/sh -c echo "deb http://cloud.r-project.org/bin/linux/debian buster-cran35/" >> /etc/apt/sources.list && apt install -y gnupg && apt-key adv --keyserver keys.gnupg.net --recv-key 'E19F5F87128899B192B1A2C2AD5F960A256A04AF' && apt-get update && apt install -y -t buster-cran35 r-base r-base-dev && rm -rf /var/cache/apt/*' returned a non-zero code: 2
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742110415
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37120/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on a change in pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
holdenk commented on a change in pull request #30694:
URL: https://github.com/apache/spark/pull/30694#discussion_r539819608
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -24,6 +24,14 @@ import org.apache.spark.internal.config.ConfigBuilder
private[spark] object Config extends Logging {
+ val DECOM_SCRIPT =
+ ConfigBuilder("spark.kubernetes.decom.script")
Review comment:
Sounds good :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30694:
URL: https://github.com/apache/spark/pull/30694#discussion_r539781022
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -24,6 +24,14 @@ import org.apache.spark.internal.config.ConfigBuilder
private[spark] object Config extends Logging {
+ val DECOM_SCRIPT =
+ ConfigBuilder("spark.kubernetes.decom.script")
Review comment:
Maybe `decom` -> `decommission`? Looks like other configuration names don't use such abbreviation .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30694:
URL: https://github.com/apache/spark/pull/30694#discussion_r539753818
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -24,6 +24,14 @@ import org.apache.spark.internal.config.ConfigBuilder
private[spark] object Config extends Logging {
+ val DECOM_SCRIPT =
Review comment:
Indentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30694:
URL: https://github.com/apache/spark/pull/30694#issuecomment-742110435
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37120/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30694: [SPARK-33724][K8S] Add decom script as a configuration param
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30694:
URL: https://github.com/apache/spark/pull/30694#discussion_r539794391
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -24,6 +24,14 @@ import org.apache.spark.internal.config.ConfigBuilder
private[spark] object Config extends Logging {
+ val DECOM_SCRIPT =
+ ConfigBuilder("spark.kubernetes.decom.script")
Review comment:
+1 for @HyukjinKwon 's suggestion. Ya, right. We use full name there, `spark.storage.decommission.enabled`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org