[jira] [Commented] (PHOENIX-5875) Optional logging for IndexTool verification

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133594#comment-17133594 ] 

Hadoop QA commented on PHOENIX-5875:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13005500/PHOENIX-5875.v1.patch
  against master branch at commit 1080422e626c2451556dc4c3f66c6c0e1010693a.
  ATTACHMENT ID: 13005500

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 11 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                    indexTool = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0, new String[0]);
+            indexTool = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null,
+            IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0,
+                        .toString(cell.getValueArray(), cell.getValueOffset(), cell.getValueLength());
+            IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0,
+            IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0,
+            IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName);
+            IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName,
+            IndexTool indexTool = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0, IndexTool.IndexVerifyType.BEFORE, new String[0]);
+            indexTool = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0, IndexTool.IndexVerifyType.BOTH, new String[0]);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3955//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3955//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3955//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3955//console

This message is automatically generated.

> Optional logging for IndexTool verification
> -------------------------------------------
>
>                 Key: PHOENIX-5875
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5875
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.0.0, 4.14.3
>            Reporter: Kadir OZDEMIR
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5875-4.x.v1.patch, PHOENIX-5875-4.x.v2.patch, PHOENIX-5875-4.x.v3.patch, PHOENIX-5875.v1.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> IndexTool logs information about each row that has a verification failure. The amount of logging can be excessive for large index tables. Also for some runs, we may want to just do incremental repair, i.e., repair only the rows that are broken, using -v BOTH or -v BEFORE, but not interested in the details of how they are broken. Thus, IndexTool should have an option to disable logging, something like, -dl (--disable-logging) BEFORE | AFTER | BOTH where BEFORE, AFTER and BOTH indicate at the which phase (before or after index repair or a both phases ) logging is disabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)