You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/05 12:20:39 UTC
[GitHub] [superset] geido opened a new pull request #13950: test: Add tests for the Dashboard FilterBar CascadeFilterControl component
geido opened a new pull request #13950:
URL: https://github.com/apache/superset/pull/13950
### SUMMARY
Adds the tests for the Dashboard FilterBar CascadeFilterControl component.
### TEST PLAN
All tests should pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13950: test: Add tests for the Dashboard FilterBar CascadeFilterControl component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13950:
URL: https://github.com/apache/superset/pull/13950#issuecomment-814188440
# [Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=h1) Report
> Merging [#13950](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=desc) (2c648a2) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `0.65%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 2c648a2 differs from pull request most recent head c651072. Consider uploading reports for the commit c651072 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13950 +/- ##
==========================================
+ Coverage 77.87% 78.53% +0.65%
==========================================
Files 935 937 +2
Lines 47375 47442 +67
Branches 5964 5976 +12
==========================================
+ Hits 36895 37260 +365
+ Misses 10323 10039 -284
+ Partials 157 143 -14
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+5.27%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `57.14% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `80.32% <ø> (ø)` | |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.34% <0.00%> (+0.88%)` | :arrow_up: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.77% <0.00%> (+1.16%)` | :arrow_up: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <0.00%> (+1.44%)` | :arrow_up: |
| ... and [45 more](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=footer). Last update [8b9c142...c651072](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #13950: test: Add tests for the Dashboard FilterBar CascadeFilterControl component
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #13950:
URL: https://github.com/apache/superset/pull/13950#issuecomment-813612447
@geido this appears to just need a lil' rebase, and then I'm happy to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13950: test: Add tests for the Dashboard FilterBar CascadeFilterControl component
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13950:
URL: https://github.com/apache/superset/pull/13950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13950: test: Add tests for the Dashboard FilterBar CascadeFilterControl component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13950:
URL: https://github.com/apache/superset/pull/13950#issuecomment-814188440
# [Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=h1) Report
> Merging [#13950](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=desc) (2c648a2) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 2c648a2 differs from pull request most recent head c651072. Consider uploading reports for the commit c651072 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13950 +/- ##
==========================================
- Coverage 77.87% 77.73% -0.14%
==========================================
Files 935 937 +2
Lines 47375 47442 +67
Branches 5964 5976 +12
==========================================
- Hits 36895 36881 -14
- Misses 10323 10395 +72
- Partials 157 166 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.27% <ø> (+0.50%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `57.14% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `80.32% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=footer). Last update [8b9c142...c651072](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13950: test: Add tests for the Dashboard FilterBar CascadeFilterControl component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13950:
URL: https://github.com/apache/superset/pull/13950#issuecomment-814188440
# [Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=h1) Report
> Merging [#13950](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=desc) (2c648a2) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `0.69%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 2c648a2 differs from pull request most recent head c651072. Consider uploading reports for the commit c651072 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13950 +/- ##
==========================================
+ Coverage 77.87% 78.57% +0.69%
==========================================
Files 935 935
Lines 47375 47375
Branches 5964 5964
==========================================
+ Hits 36895 37224 +329
+ Misses 10323 10007 -316
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+5.27%)` | :arrow_up: |
| javascript | `67.12% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.34% <0.00%> (+0.88%)` | :arrow_up: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.77% <0.00%> (+1.16%)` | :arrow_up: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <0.00%> (+1.44%)` | :arrow_up: |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <0.00%> (+1.85%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `73.58% <0.00%> (+1.88%)` | :arrow_up: |
| ... and [42 more](https://codecov.io/gh/apache/superset/pull/13950/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=footer). Last update [8b9c142...c651072](https://codecov.io/gh/apache/superset/pull/13950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org