[jira] [Commented] (SLING-4551) Performance: Use static logger in ResourceIterator

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386338#comment-14386338 ] 

Carsten Ziegeler commented on SLING-4551:
-----------------------------------------

I'm not against changing this - I think we use a static logger for frequently created objects already in other places and this change is inline. However, 1% is really not that much, I would suggest looking at the large blocks that kill performance

> Performance: Use static logger in ResourceIterator
> --------------------------------------------------
>
>                 Key: SLING-4551
>                 URL: https://issues.apache.org/jira/browse/SLING-4551
>             Project: Sling
>          Issue Type: Improvement
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.2.4
>            Reporter: Joel Richard
>            Priority: Minor
>              Labels: performance
>
> The logger lookup in org.apache.sling.resourceresolver.impl.helper.ResourceIterator adds 1% rendering overhead because the logger variable is an instance variable and the class is used very often. This can be avoided simply by using a static logger.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)