You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "NobiGo (via GitHub)" <gi...@apache.org> on 2024/10/29 00:42:08 UTC
[PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
NobiGo opened a new pull request, #4021:
URL: https://github.com/apache/calcite/pull/4021
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo commented on PR #4021:
URL: https://github.com/apache/calcite/pull/4021#issuecomment-2561519557
I will merge this PR in the next 48 hours if there are no more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4021:
URL: https://github.com/apache/calcite/pull/4021#issuecomment-2442964973
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4021) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4021&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4021&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4021&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4021&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4021&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4021)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4021:
URL: https://github.com/apache/calcite/pull/4021#issuecomment-2524847311
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4021:
URL: https://github.com/apache/calcite/pull/4021#issuecomment-2561051168
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4021) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4021&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4021&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4021&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4021&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4021&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4021)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #4021:
URL: https://github.com/apache/calcite/pull/4021#discussion_r1820561647
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java:
##########
@@ -200,15 +204,17 @@ public RelOptPredicateList getPredicates(Project project,
project.getRowType().getFieldCount());
for (Ord<RexNode> expr : Ord.zip(project.getProjects())) {
- if (expr.e instanceof RexInputRef) {
- int sIdx = ((RexInputRef) expr.e).getIndex();
- m.set(sIdx, expr.i);
+ RexNode rexNode = simplify.simplify(expr.e);
+ Ord<RexNode> newExpr = new Ord<>(expr.i, rexNode);
+ if (newExpr.e instanceof RexInputRef) {
Review Comment:
Maybe adding some javadoc would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo commented on PR #4021:
URL: https://github.com/apache/calcite/pull/4021#issuecomment-2561518978
This PR has been fixed by CALCITE-6586. I only added some tests to confirm we don't need to optimize this in RelMdPredicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #4021:
URL: https://github.com/apache/calcite/pull/4021#discussion_r1820561647
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java:
##########
@@ -200,15 +204,17 @@ public RelOptPredicateList getPredicates(Project project,
project.getRowType().getFieldCount());
for (Ord<RexNode> expr : Ord.zip(project.getProjects())) {
- if (expr.e instanceof RexInputRef) {
- int sIdx = ((RexInputRef) expr.e).getIndex();
- m.set(sIdx, expr.i);
+ RexNode rexNode = simplify.simplify(expr.e);
+ Ord<RexNode> newExpr = new Ord<>(expr.i, rexNode);
+ if (newExpr.e instanceof RexInputRef) {
Review Comment:
Maybe adding some javadoc would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo merged PR #4021:
URL: https://github.com/apache/calcite/pull/4021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org