You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ryan Thiessen (Created) (JIRA)" <ji...@apache.org> on 2011/11/07 20:48:52 UTC
[jira] [Created] (HBASE-4756) Enable tab-completion in HBase shell
Enable tab-completion in HBase shell
------------------------------------
Key: HBASE-4756
URL: https://issues.apache.org/jira/browse/HBASE-4756
Project: HBase
Issue Type: Improvement
Components: shell
Reporter: Ryan Thiessen
Priority: Minor
Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
This would be as simple as:
- CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
+ CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145959#comment-13145959 ]
Hadoop QA commented on HBASE-4756:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502824/HBASE-4756_v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -164 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/213//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/213//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/213//console
This message is automatically generated.
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Attachments: HBASE-4756.patch, HBASE-4756_v2.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146189#comment-13146189 ]
Hudson commented on HBASE-4756:
-------------------------------
Integrated in HBase-TRUNK #2421 (See [https://builds.apache.org/job/HBase-TRUNK/2421/])
HBASE-4756 Enable tab-completion in HBase shell
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/bin/hbase
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4756.patch, HBASE-4756_v2.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145857#comment-13145857 ]
Ted Yu commented on HBASE-4756:
-------------------------------
@Ryan:
Please issue the 'svn diff ' command at the root level of hbase.
After attaching patch v2, you can 'Cancel Patch' and 'Submit Patch' again.
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Attachments: HBASE-4756.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145850#comment-13145850 ]
Hadoop QA commented on HBASE-4756:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502819/HBASE-4756.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/212//console
This message is automatically generated.
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Attachments: HBASE-4756.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4756) Enable tab-completion in HBase shell
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4756:
-------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Nice one Ryan. Committed to trunk and branch.
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4756.patch, HBASE-4756_v2.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4756) Enable tab-completion in HBase shell
Posted by "Ryan Thiessen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Thiessen updated HBASE-4756:
---------------------------------
Attachment: HBASE-4756.patch
This is a svn-based diff. I'm a bit new to this so apologies if I'm doing this wrong.
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Attachments: HBASE-4756.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Ryan Thiessen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145832#comment-13145832 ]
Ryan Thiessen commented on HBASE-4756:
--------------------------------------
A simple example:
org<tab>
longer example:
import org.apache.hadoop.hbase.HBaseConfiguration
import org.apache.hadoop.hbase.HConstants
import org.apache.hadoop.hbase.client.HBaseAdmin
import org.apache.hadoop.hbase.util.Bytes
config = HBaseConfiguration.new
config.set 'fs.default.name', config.get(HConstants::HBASE_DIR)
admin = HBaseAdmin.new(config)
row = scanner = admin.listTables[0]
row.getFamilies.<tab>
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4756) Enable tab-completion in HBase shell
Posted by "Ryan Thiessen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Thiessen updated HBASE-4756:
---------------------------------
Status: Patch Available (was: Open)
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Attachments: HBASE-4756.patch, HBASE-4756_v2.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146133#comment-13146133 ]
Hudson commented on HBASE-4756:
-------------------------------
Integrated in HBase-0.92 #120 (See [https://builds.apache.org/job/HBase-0.92/120/])
HBASE-4756 Enable tab-completion in HBase shell
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/bin/hbase
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4756.patch, HBASE-4756_v2.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4756) Enable tab-completion in HBase shell
Posted by "Ryan Thiessen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Thiessen updated HBASE-4756:
---------------------------------
Status: Patch Available (was: Open)
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4756) Enable tab-completion in HBase shell
Posted by "Ryan Thiessen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Thiessen updated HBASE-4756:
---------------------------------
Status: Open (was: Patch Available)
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Attachments: HBASE-4756.patch, HBASE-4756_v2.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4756) Enable tab-completion in HBase shell
Posted by "Ryan Thiessen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Thiessen updated HBASE-4756:
---------------------------------
Attachment: HBASE-4756_v2.patch
Attached new patch from base SVN
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
> Attachments: HBASE-4756.patch, HBASE-4756_v2.patch
>
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145828#comment-13145828 ]
Nicolas Spiegelberg commented on HBASE-4756:
--------------------------------------------
+1 on change. Just wanted to verify with the other committers that there wasn't some reason this was disabled...
@Ted : this is normal autocompletion across the Ruby lexical analyzer. TAB will give a complete function list on whitespace boundaries & won't filter unless you type in words to invoke a prefix filter.
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4756) Enable tab-completion in HBase
shell
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145817#comment-13145817 ]
Ted Yu commented on HBASE-4756:
-------------------------------
With the proposed change (I tried create <tab> with same result):
{code}
hbase(main):001:0> help
Display all 407 possibilities? (y or n)
== === =~ ARGF
ARGV ArgumentError Array ArrayJavaProxy
ArrayJavaProxyCreator BEGIN Bignum Binding
CROSS_COMPILING Class Comparable ConcreteJavaProxy
ConcurrencyError Config Continuation Data
Dir END ENV ENV_JAVA
{code}
@Ryan:
Can you give some examples ?
> Enable tab-completion in HBase shell
> ------------------------------------
>
> Key: HBASE-4756
> URL: https://issues.apache.org/jira/browse/HBASE-4756
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Reporter: Ryan Thiessen
> Priority: Minor
>
> Tab-completion in the HBase irb shell is nifty for debugging. Without the +X-O option it frequently crashes. Is there any reason not to enable this by default?
> This would be as simple as:
> - CLASS="org.jruby.Main ${HBASE_HOME}/bin/hirb.rb"
> + CLASS="org.jruby.Main -X+O ${HBASE_HOME}/bin/hirb.rb"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira