You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2017/05/03 20:58:21 UTC
[GitHub] nifi pull request #1745: NIFI-3791 - added back pressure data into S2SStatus...
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1745
NIFI-3791 - added back pressure data into S2SStatusReportingTask
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-3791
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1745
----
commit 9af5ca61fdc33c333be64a136afedcb78bbcfba5
Author: Pierre Villard <pi...@gmail.com>
Date: 2017-05-03T20:56:22Z
NIFI-3791 - added back pressure data into S2SStatusReportingTask
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1745: NIFI-3791 - added back pressure data into S2SStatus...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1745: NIFI-3791 - added back pressure data into S2SStatusReporti...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1745
@pvillard31 @alopresto I've reviewed the code, build and test the change to see if I can see any odd exceptions, but I haven't encountered any so far. I can see back-pressure status is reported properly. LGTM, +1.
I'm going to merge this into master. Thanks for the improvement!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1745: NIFI-3791 - added back pressure data into S2SStatusReporti...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1745
Ran a sample flow but was getting some odd exceptions. Coordinating with Pierre offline but recommend another party reviews this PR. As it is not going in 1.2.0, there is plenty of time to have a person with more knowledge of the internals do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1745: NIFI-3791 - added back pressure data into S2SStatusReporti...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1745
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---