You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/28 09:11:20 UTC
[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15578
to review the following change.
Change subject: rpc: remove kudu::Bind usage from ServerPicker
......................................................................
rpc: remove kudu::Bind usage from ServerPicker
Snuck in a Bind removal from batcher.cc too.
Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
---
M src/kudu/client/batcher.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc.h
6 files changed, 18 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/15578/1
--
To view, visit http://gerrit.cloudera.org:8080/15578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
Gerrit-Change-Number: 15578
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15578 )
Change subject: rpc: remove kudu::Bind usage from ServerPicker
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
Gerrit-Change-Number: 15578
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15578 )
Change subject: rpc: remove kudu::Bind usage from ServerPicker
......................................................................
rpc: remove kudu::Bind usage from ServerPicker
Snuck in a Bind removal from batcher.cc too.
Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
Reviewed-on: http://gerrit.cloudera.org:8080/15578
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/batcher.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc.h
6 files changed, 18 insertions(+), 20 deletions(-)
Approvals:
Adar Dembo: Verified
Alexey Serbin: Looks good to me, approved
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
Gerrit-Change-Number: 15578
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15578 )
Change subject: rpc: remove kudu::Bind usage from ServerPicker
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
Gerrit-Change-Number: 15578
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 02:54:17 +0000
Gerrit-HasComments: No
[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15578 )
Change subject: rpc: remove kudu::Bind usage from ServerPicker
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins, known race.
--
To view, visit http://gerrit.cloudera.org:8080/15578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
Gerrit-Change-Number: 15578
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 29 Mar 2020 21:19:44 +0000
Gerrit-HasComments: No
[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15578 )
Change subject: rpc: remove kudu::Bind usage from ServerPicker
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40554f59152eec1b84171f16f1fa2b91aa3a1e55
Gerrit-Change-Number: 15578
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 05:54:10 +0000
Gerrit-HasComments: No