You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/04/08 15:40:04 UTC
[GitHub] [submarine] cchung100m opened a new pull request #257: Submarine
464. [WORKBENCH] Renew the filepath and screenshot for the workbench doc
cchung100m opened a new pull request #257: Submarine 464. [WORKBENCH] Renew the filepath and screenshot for the workbench doc
URL: https://github.com/apache/submarine/pull/257
### What is this PR for?
Documentation improvement.
### What type of PR is it?
[Improvement | Documentation]
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-464
### How should this be tested?
https://travis-ci.com/github/cchung100m/submarine/builds/159393276
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] asfgit closed pull request #257: SUBMARINE-464. Renew
the filepath and screenshot for the workbench doc
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #257: SUBMARINE-464. Renew the filepath and screenshot for the workbench doc
URL: https://github.com/apache/submarine/pull/257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] cchung100m commented on issue #257: SUBMARINE-464.
Renew the filepath and screenshot for the workbench doc
Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #257: SUBMARINE-464. Renew the filepath and screenshot for the workbench doc
URL: https://github.com/apache/submarine/pull/257#issuecomment-611044239
cc @liuxunorg @pingsutw @kevin85421
This PR is a minor change and I would appreciate that if you can help to review/manage it, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] pingsutw commented on a change in pull request #257:
SUBMARINE-464. Renew the filepath and screenshot for the workbench doc
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #257: SUBMARINE-464. Renew the filepath and screenshot for the workbench doc
URL: https://github.com/apache/submarine/pull/257#discussion_r405898329
##########
File path: docs/development/README.md
##########
@@ -50,49 +50,49 @@ Waiting for supplement
Waiting for supplement
### 2.6. submarine-sdk
-+ **pysubmarine**: By using Submarine's python sdk library, you can output
++ **pysubmarine**: By using Submarine's python sdk library, you can output
metrics such as metrics when the algorithm is executed in your python program by
importing pysubmarine during the development of the machine learning algorithm.
### 2.7. submarine-workbench
-+ **workbench-server**: is a Jetty-based web server service. Workbench-server
-provides RESTful interface and Websocket interface. The RESTful interface
-provides workbench-web with management capabilities for databases such as
++ **workbench-server**: is a Jetty-based web server service. Workbench-server
+provides RESTful interface and Websocket interface. The RESTful interface
+provides workbench-web with management capabilities for databases such as
project, department, user, and role.
-+ **workbench-web**: is a web front-end service based on `VUE.js` framework.
-With `workbench-web` users can manage Submarine project, department, user, role
-through browser. You can also use the notebook to develop machine learning
++ **workbench-web**: is a web front-end service based on `VUE.js` framework.
+With `workbench-web` users can manage Submarine project, department, user, role
+through browser. You can also use the notebook to develop machine learning
algorithms, model release and other lifecycle management.
## 3. Submarine Workbench Development Guide
Submarine workbench consists of three modules: workbench-server, workbench-web
-and database.
+and database.
-First, you need to clone the entire Submarine project:
+First, you need to clone the entire Submarine project:
```
git clone https://github.com/hadoopsubmarine/submarine.git
Review comment:
should change to `git clone https://github.com/submarine/submarine.git`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] pingsutw commented on issue #257: SUBMARINE-464. Renew
the filepath and screenshot for the workbench doc
Posted by GitBox <gi...@apache.org>.
pingsutw commented on issue #257: SUBMARINE-464. Renew the filepath and screenshot for the workbench doc
URL: https://github.com/apache/submarine/pull/257#issuecomment-611271524
@cchung100m Thanks for the patch, overall LGTM.
A suggestion in the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services