You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/20 15:17:02 UTC

[GitHub] [pulsar] rodyarantes opened a new pull request #6575: Removed deprecated -XX:+AggressiveOpts

rodyarantes opened a new pull request #6575: Removed deprecated -XX:+AggressiveOpts
URL: https://github.com/apache/pulsar/pull/6575
 
 
   The Java VM flag -XX:+AggressiveOpts was deprecated in JDK 11
   
   ### Motivation
   
   Unable to start pulsar on JDK 11+.
   
   ```
   Unrecognized VM option 'AggressiveOpts'
   Error: Could not create the Java Virtual Machine.
   Error: A fatal exception has occurred. Program will exit.
   ```
   Error occurred when running startup command.
   ```
   ./bin/pulsar standalone (all modes)
   ```
   
   ### Modifications
   
   Removed JVM flag:
   ```
   -XX:+AggressiveOpts
   ```
   
   ### Verifying this change
   
   This change is already covered by existing tests, such as running **bin/pulsar**
   
   ### Does this pull request potentially affect one of the following parts: no
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: yes
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: yes
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #6575: Removed deprecated -XX:+AggressiveOpts

Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6575: Removed deprecated -XX:+AggressiveOpts
URL: https://github.com/apache/pulsar/pull/6575#issuecomment-610779554
 
 
   It was fixed by #6689 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie closed pull request #6575: Removed deprecated -XX:+AggressiveOpts

Posted by GitBox <gi...@apache.org>.
sijie closed pull request #6575: Removed deprecated -XX:+AggressiveOpts
URL: https://github.com/apache/pulsar/pull/6575
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #6575: Removed deprecated -XX:+AggressiveOpts

Posted by GitBox <gi...@apache.org>.
merlimat commented on issue #6575: Removed deprecated -XX:+AggressiveOpts
URL: https://github.com/apache/pulsar/pull/6575#issuecomment-601761313
 
 
   👍 The flag is also being passed in multiple scripts: 
   
   ```
   $ git grep -l AggressiveOpts
   conf/bkenv.sh
   conf/pulsar_env.sh
   deployment/kubernetes/aws/bookkeeper.yaml
   deployment/kubernetes/aws/broker.yaml
   deployment/kubernetes/aws/zookeeper.yaml
   deployment/kubernetes/helm/pulsar/values-mini.yaml
   deployment/kubernetes/helm/pulsar/values.yaml
   deployment/terraform-ansible/templates/pulsar_env.sh
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services