Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

["epugh (via GitHub)" <gi...@apache.org>]

epugh commented on code in PR #2452:
URL: https://github.com/apache/solr/pull/2452#discussion_r3871534370


##########
solr/core/src/java/org/apache/solr/handler/component/SearchComponent.java:
##########
@@ -110,16 +111,20 @@ public void initializeMetrics(SolrMetricsContext parentContext, Attributes attri
     this.solrMetricsContext = parentContext.getChildContext(this);
   }
 
-  public static final Map<String, Class<? extends SearchComponent>> standard_components =
-      Map.of(
-          HighlightComponent.COMPONENT_NAME, HighlightComponent.class,
-          QueryComponent.COMPONENT_NAME, QueryComponent.class,
-          FacetComponent.COMPONENT_NAME, FacetComponent.class,
-          FacetModule.COMPONENT_NAME, FacetModule.class,
-          MoreLikeThisComponent.COMPONENT_NAME, MoreLikeThisComponent.class,
-          StatsComponent.COMPONENT_NAME, StatsComponent.class,
-          DebugComponent.COMPONENT_NAME, DebugComponent.class,
-          RealTimeGetComponent.COMPONENT_NAME, RealTimeGetComponent.class,
-          ExpandComponent.COMPONENT_NAME, ExpandComponent.class,
-          TermsComponent.COMPONENT_NAME, TermsComponent.class);
+  public static final Map<String, Class<? extends SearchComponent>> STANDARD_COMPONENTS;

Review Comment:
   just passed the limit of `Map.of`!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org