Re: [PR] chore: Use twox-hash 2.0 xxhash64 oneshot api instead of custom implementation [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on PR #1041:
URL: https://github.com/apache/datafusion-comet/pull/1041#issuecomment-2440157392

   > How should I proceed with the pipeline failure which comes from a new clippy rule (manual_pattern_char_comparison) introduced in 1.81.0? Should I apply the suggestion or create a pull request with the upgrade to 1.81.0 and apply it there or do you have a different suggestion?
   
   I think it would be fine to apply the change in this PR.
   
   I checked our policy on which Rust versions we support, and upgrading to 1.81.0 is consistent with that policy.
   
   ```
   DataFusion's Minimum Required Stable Rust Version (MSRV) policy is to support stable 4 latest Rust versions OR the stable minor Rust version as of 4 months, whichever is lower.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org