You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2024/04/01 05:24:45 UTC
[PR] Introducing --latest for generate-issue-content-helm-chart command [airflow]
amoghrajesh opened a new pull request, #38648:
URL: https://github.com/apache/airflow/pull/38648
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
related #38250
Introducing --latest flag that gets the realistic values for helm charts from the https://airflow.apache.org/_gen/packages-metadata.json and compares to latest state of HEAD.
Example:
```
➜ airflow git:(latestHelm) ✗ breeze release-management generate-issue-content-helm-chart --limit-pr-count 10 --latest --verbose
/Users/adesai/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/urllib3/__init__.py:34: NotOpenSSLWarning: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'. See: https://github.com/urllib3/urllib3/issues/3020
warnings.warn(
Latest stable version of helm chart is 1.13.1
Environment variable VERSION not set, setting current release version as 'HEAD' for helm chart release
/Users/adesai/Documents/OSS/airflow/dev/breeze/src/airflow_breeze/commands /Users/adesai/Documents/OSS/airflow
Command to run: 'git log --pretty=format:%H %h %cd %s --date=short helm-chart/1.13.1...HEAD -- chart/'
Retrieving PR#38510: https://github.com/apache/airflow/pull/38510
Retrieving PR#38478: https://github.com/apache/airflow/pull/38478
Retrieving 10 PRs ━━━━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 10% -:--:--
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introducing --latest for generate-issue-content-helm-chart command [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #38648:
URL: https://github.com/apache/airflow/pull/38648#discussion_r1546130623
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -3266,16 +3270,32 @@ def generate_issue_content(
if latest:
import requests
- response = requests.get("https://pypi.org/pypi/apache-airflow/json")
- response.raise_for_status()
- latest_released_version = response.json()["info"]["version"]
- previous = str(latest_released_version)
- current = os.getenv("VERSION", "HEAD")
- if current == "HEAD":
- get_console().print(
- "\n[warning]Environment variable VERSION not set, setting current release "
- "version as 'HEAD'\n"
- )
+ if not is_helm_chart:
Review Comment:
Yeah that makes sense. Making the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introducing --latest for generate-issue-content-helm-chart command [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #38648:
URL: https://github.com/apache/airflow/pull/38648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introducing --latest for generate-issue-content-helm-chart command [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #38648:
URL: https://github.com/apache/airflow/pull/38648#discussion_r1546124599
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -3266,16 +3270,32 @@ def generate_issue_content(
if latest:
import requests
- response = requests.get("https://pypi.org/pypi/apache-airflow/json")
- response.raise_for_status()
- latest_released_version = response.json()["info"]["version"]
- previous = str(latest_released_version)
- current = os.getenv("VERSION", "HEAD")
- if current == "HEAD":
- get_console().print(
- "\n[warning]Environment variable VERSION not set, setting current release "
- "version as 'HEAD'\n"
- )
+ if not is_helm_chart:
Review Comment:
NIT: revert this check to avoid `not` and do not do the second check. Also you could extract what's inside the if statemantes to `get_latest_helm_chart()` and `get_latest_airflow` methods - and move them somwhere to the `utils` folder. That would make them reusable for other cases possibly.
```
if is_helm_chart:
....
else:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introducing --latest for generate-issue-content-helm-chart command [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #38648:
URL: https://github.com/apache/airflow/pull/38648#issuecomment-2029182698
@potiuk the next step in the direction for making this command cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introducing --latest for generate-issue-content-helm-chart command [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #38648:
URL: https://github.com/apache/airflow/pull/38648#issuecomment-2029405800
Random failure, retriggered now.
@potiuk BTW, the job runs well: https://github.com/apache/airflow/actions/runs/8504852198/job/23292475501?pr=38648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org