You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2023/06/28 19:04:00 UTC
[jira] [Comment Edited] (CASSANDRA-17909) Clean SyncUtil from dead code and update it for new JDK versions
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738249#comment-17738249 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17909 at 6/28/23 7:03 PM:
--------------------------------------------------------------------------
The SyncUtil class was updated for JDK11 and 17.
Notable changes:
* old Java 7 and 8 code was removed. This effectively makes this patch commit blocked on CASSANDRA-18255
* We should not be throwing any more UnsupportedOperationException [here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L126-L127]. [This|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L125] comment is not applicable anymore since [this fix|https://github.com/openjdk/jdk11u-dev/commit/a7b3a19ec476e31d08146628fe51a4b107086c78] in JDK11.
I suspect we want to port a minimal fix for JDK11 on previous branches, but let's see first whether my trunk patch will be accepted.
[trunk PR|https://github.com/apache/cassandra/pull/2456], [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17909-trunk]
I can see only the known failures from the table in CASSANDRA-16895 in CI.
[~jlewandowski], could you review this one?
was (Author: e.dimitrova):
The SyncUtil class was updated for JDK11 and 17.
Notable changes:
* old Java 7 and 8 code was removed. This effectively makes this patch commit blocked on CASSANDRA-18255
* We should not be throwing any more UnsupportedOperationException [here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L126-L127]. [This|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L125] comment is not applicable anymore since [this fix|https://github.com/openjdk/jdk11u-dev/commit/a7b3a19ec476e31d08146628fe51a4b107086c78] fix in JDK11.
I suspect we want to port a minimal fix for JDK11 on previous branches, but let's see first whether my trunk patch will be accepted.
[trunk PR|https://github.com/apache/cassandra/pull/2456], [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17909-trunk]
I can see only the known failures from the table in CASSANDRA-16895 in CI.
[~jlewandowski], could you review this one?
> Clean SyncUtil from dead code and update it for new JDK versions
> ----------------------------------------------------------------
>
> Key: CASSANDRA-17909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17909
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] (JDK 7) in SyncUtil.
> From a very quick skim _I think_ the [Java 8 section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at least until we have JDK11. To be revisited.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org