You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hivemall.apache.org by myui <gi...@git.apache.org> on 2018/08/24 05:57:30 UTC

[GitHub] incubator-hivemall pull request #156: [HIVEMALL-211][BUGFIX] Fixed Optimizer...

GitHub user myui opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/156

    [HIVEMALL-211][BUGFIX] Fixed Optimizer for regularization updates

    ## What changes were proposed in this pull request?
    
    This PR fixes a bug of regularization scheme of Optimizer.
    
    ## What type of PR is it?
    
    Bug Fix
    
    ## What is the Jira issue?
    
    https://issues.apache.org/jira/browse/HIVEMALL-211
    
    ## How was this patch tested?
    
    unit tests, manual tests on EMR
    
    ## Checklist
    
    (Please remove this section if not needed; check `x` for YES, blank for NO)
    
    - [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit?
    - [ ] Did you run system tests on Hive (or Spark)?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/myui/incubator-hivemall HIVEMALL-211

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 84d1aeb9ca06fd5e6d83686b183543a1d57b06c8
Author: Makoto Yui <my...@...>
Date:   2018-08-24T05:54:23Z

    Fixed regularization scheme and updated Adagrad rule

----


---

[GitHub] incubator-hivemall issue #156: [HIVEMALL-211][BUGFIX] Fixed Optimizer for re...

Posted by myui <gi...@git.apache.org>.

Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/156
  
    @takuti fixed in https://github.com/apache/incubator-hivemall/pull/156/commits/84d1aeb9ca06fd5e6d83686b183543a1d57b06c8 FYI


---

[GitHub] incubator-hivemall issue #156: [HIVEMALL-211][BUGFIX] Fixed Optimizer for re...

Posted by myui <gi...@git.apache.org>.

Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/156
  
    confirmed optimizer is working fine using a9a classification.
    https://gist.github.com/myui/a33a06ff3cf7db0e63ba46ec29703e43


---

[GitHub] incubator-hivemall pull request #156: [HIVEMALL-211][BUGFIX] Fixed Optimizer...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hivemall/pull/156


---