You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ryanmcginnis (via GitHub)" <gi...@apache.org> on 2026/10/16 22:19:22 UTC

[PR] Update nlp_tensorflow_streaming.ipynb [beam]

ryanmcginnis opened a new pull request, #40641:
URL: https://github.com/apache/beam/pull/40641

   Update link to YouTube Data API. Also, removes link to code samples because they aren't actively being maintained and/or they're in the process of being updated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update nlp_tensorflow_streaming.ipynb [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40641:
URL: https://github.com/apache/beam/pull/40641#issuecomment-6226010034

   Assigning reviewers:
   
   R: @damccorm added as fallback since no labels match configuration
   Backup reviewer: tvalentyn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update nlp_tensorflow_streaming.ipynb [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #40641:
URL: https://github.com/apache/beam/pull/40641#discussion_r4299868454


##########
examples/notebooks/beam-ml/nlp_tensorflow_streaming.ipynb:
##########
@@ -725,8 +725,6 @@
       "source": [
         "## Extracting and sending comments to Pub/Sub\n",
         "YouTube API provides an interface for accessing YouTube data. First, we need to enable YouTube API on the Google Cloud Console project. After that, we need to create a credential, which will further provide an API key. This API key, along with a video ID can be used to access data of that YouTube video. The Publisher created earlier is used to publish each comment to Pub/Sub.\n",

Review Comment:
   **🔴 Critical**: Removing the subsequent lines makes this the last element in the `source` JSON array, leaving an invalid trailing comma that breaks JSON parsing for this notebook.
   
   ```suggestion
           "YouTube API provides an interface for accessing YouTube data. First, we need to enable YouTube API on the Google Cloud Console project. After that, we need to create a credential, which will further provide an API key. This API key, along with a video ID can be used to access data of that YouTube video. The Publisher created earlier is used to publish each comment to Pub/Sub.\n"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update nlp_tensorflow_streaming.ipynb [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #40641:
URL: https://github.com/apache/beam/pull/40641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org