You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2012/11/02 23:54:12 UTC
[jira] [Created] (HBASE-7090) HMaster#splitLogAndExpireIfOnline
actually does it if the server is NOT online
Jimmy Xiang created HBASE-7090:
----------------------------------
Summary: HMaster#splitLogAndExpireIfOnline actually does it if the server is NOT online
Key: HBASE-7090
URL: https://issues.apache.org/jira/browse/HBASE-7090
Project: HBase
Issue Type: Bug
Components: master, Region Assignment
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Minor
This has been there for some time. It is a surprise to find it is reversed actually. Did I missing anything?
I think it really means to do it if the server is online.
{noformat}
private void splitLogAndExpireIfOnline(final ServerName sn)
throws IOException {
if (sn == null || !serverManager.isServerOnline(sn)) {
return;
}
LOG.info("Forcing splitLog and expire of " + sn);
fileSystemManager.splitLog(sn);
serverManager.expireServer(sn);
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-7090) HMaster#splitLogAndExpireIfOnline
actually does it if the server is NOT online
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang resolved HBASE-7090.
--------------------------------
Resolution: Invalid
The code is right actually. Invalid issue.
> HMaster#splitLogAndExpireIfOnline actually does it if the server is NOT online
> ------------------------------------------------------------------------------
>
> Key: HBASE-7090
> URL: https://issues.apache.org/jira/browse/HBASE-7090
> Project: HBase
> Issue Type: Bug
> Components: master, Region Assignment
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
>
> This has been there for some time. It is a surprise to find it is reversed actually. Did I missing anything?
> I think it really means to do it if the server is online.
> {noformat}
> private void splitLogAndExpireIfOnline(final ServerName sn)
> throws IOException {
> if (sn == null || !serverManager.isServerOnline(sn)) {
> return;
> }
> LOG.info("Forcing splitLog and expire of " + sn);
> fileSystemManager.splitLog(sn);
> serverManager.expireServer(sn);
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira