You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/28 05:00:27 UTC
Re: Review Request 71303: Enabled role sorters to track frameworks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71303/
-----------------------------------------------------------
(Updated Aug. 27, 2019, 10 p.m.)
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Summary (updated)
-----------------
Enabled role sorters to track frameworks.
Bugs: MESOS-9917
https://issues.apache.org/jira/browse/MESOS-9917
Repository: mesos
Description (updated)
-------
This paves the way for deprecating the framework sorters.
Four new public sorter methods are added:
```
addFramework(role, framework)
removeFramework(role, framework)
contains(framework)
sortFrameworks(role)
```
Diffs (updated)
-----
src/master/allocator/mesos/sorter/drf/metrics.cpp 82cb5300c5a498d2042562c660a9bd5108158538
src/master/allocator/mesos/sorter/drf/sorter.hpp f157ec6153325b0457ab1bc76f9eb018712d753a
src/master/allocator/mesos/sorter/drf/sorter.cpp 09889cdf3dc8c0e773b8e2e24154fb0edd2cc254
src/master/allocator/mesos/sorter/random/sorter.hpp 8663ccd4ccdd36c8ea7513b492d3f46a0b15ff5c
src/master/allocator/mesos/sorter/random/sorter.cpp 60a5797472460a8d3d9be938af9f6711ea51d484
src/master/allocator/mesos/sorter/sorter.hpp 52b8a7b57bf17759311b32aa56c26e614119b773
Diff: https://reviews.apache.org/r/71303/diff/2/
Changes: https://reviews.apache.org/r/71303/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu