You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/03 06:21:33 UTC

[GitHub] [spark] HyukjinKwon commented on pull request #35690: [SPARK-38335][SQL] Implement parser support for DEFAULT column values

HyukjinKwon commented on pull request #35690:
URL: https://github.com/apache/spark/pull/35690#issuecomment-1057716458


   Adding the default support itself should be fine - it's pretty common up to my best knowledge. My only concern is the breaking behavior (https://github.com/apache/spark/pull/35690#issuecomment-1057620996). I am fine w/ this as long as this matches w/ most of DBMSes. I suspect it's less critical since it failed before but now works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org