[PR] Mpfs corepwm fixes [nuttx]

["jlaitine (via GitHub)" <gi...@apache.org>]

jlaitine opened a new pull request, #13604:
URL: https://github.com/apache/nuttx/pull/13604

   ## Summary
   
   This adds small fixes for mpfs corepwm driver. The corepwm is a Microchip's IP block (freely usable), which can be instantiated on the FPGA of the MPFS chip.
   
   ## Impact
   
   Only MPFS targets using CorePWM IP
   
   ## Testing
   
   Tested on a custom MPFS hardware
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Mpfs corepwm fixes [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13604:
URL: https://github.com/apache/nuttx/pull/13604#issuecomment-2373561438

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, the PR does not fully meet the NuttX requirements.**
   
   **Missing Information:**
   
   * **Summary:**
       * Lacks specific details about the fixes made to the mpfs corepwm driver. What exactly was fixed? How does the change work?
   * **Impact:**
       * Needs more specific details on the impact to MPFS targets using CorePWM IP.  Will any user-facing functionality change? 
   * **Testing:**
       * Specify the OS, CPU, and compiler used on your build host.
       * Provide more details about your custom MPFS hardware (e.g., specific MPFS chip used).
       * The testing logs sections are empty. Provide actual logs demonstrating the issue before the change and the successful outcome after the change.
   
   **Recommendations:**
   
   1. **Elaborate on the Summary:**  Clearly describe the specific issues the PR addresses within the mpfs corepwm driver. Explain the technical implementation of the fixes.
   2. **Provide Specific Impact Details:** Detail any changes in behavior that users working with MPFS CorePWM IP might experience.
   3. **Complete the Testing Section:**  Fill out the requested details about your build host and target hardware. Include relevant snippets from your testing logs that demonstrate the problem before the fix and the correct behavior after applying the fix. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Mpfs corepwm fixes [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #13604:
URL: https://github.com/apache/nuttx/pull/13604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org