You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2020/11/03 17:50:00 UTC

[jira] [Resolved] (HBASE-25210) RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

     [ https://issues.apache.org/jira/browse/HBASE-25210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Stack resolved HBASE-25210.
-----------------------------------
    Fix Version/s: 3.0.0-alpha-1
     Hadoop Flags: Reviewed
       Resolution: Fixed

Merged to master branch. [~niuyulin] brought up this change on the dev mailing list at [http://apache-hbase.679495.n3.nabble.com/DISCUSS-Deprecate-isOffline-and-isSplitParent-in-RegionInfo-td4108550.html] No objection noted. Thanks for the PR [~niuyulin]

> RegionInfo.isOffline is now a duplication with RegionInfo.isSplit
> -----------------------------------------------------------------
>
>                 Key: HBASE-25210
>                 URL: https://issues.apache.org/jira/browse/HBASE-25210
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Duo Zhang
>            Assignee: niuyulin
>            Priority: Major
>             Fix For: 3.0.0-alpha-1
>
>
> The only place, where we set it to true is in splitRegion, and at the same time we will set split to true.
> So in general, I suggest that we deprecated isOffline and isSplitParent in RegionInfo, only leave the isSplit method. And in RegionInfoBuilder, we deprecated setOffline and only leave the setSplit method.
> This could make our code base cleaner.
> And for serialization compatibility, we'd better still keep the split and offline fields in the actual RegionInfo datastructure for a while.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)