You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/12/29 16:22:46 UTC
[PR] Remove partition_mode parameter from HashJoinExec::swap_inputs [datafusion]
alamb opened a new pull request, #13940:
URL: https://github.com/apache/datafusion/pull/13940
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
Test out the question of "why bother to pass this parameter" from @berkaysynnada on https://github.com/apache/datafusion/pull/13910#discussion_r1898451972
## What changes are included in this PR?
1, Remove partition_mode parameter from HashJoinExec::swap_inputs
## Are these changes tested?
By CI
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove partition_mode parameter from HashJoinExec::swap_inputs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #13940:
URL: https://github.com/apache/datafusion/pull/13940#issuecomment-2566490717
Seems there are unit tests (though no end to end tests) that fail without this parameter. I am not sure why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove partition_mode parameter from HashJoinExec::swap_inputs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #13940: Remove partition_mode parameter from HashJoinExec::swap_inputs
URL: https://github.com/apache/datafusion/pull/13940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org