[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8443: [contrib] Add Mapbox API key variable to docker compose file

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8443: [contrib] Add Mapbox API key variable to docker compose file
URL: https://github.com/apache/incubator-superset/pull/8443#discussion_r343194077
 
 

 ##########
 File path: contrib/docker/docker-compose.yml
 ##########
 @@ -42,6 +42,8 @@ services:
       dockerfile: contrib/docker/Dockerfile
     restart: unless-stopped
     environment:
+      # Add Mapxbox access token to correctly display deck.gl visualizations
+      #MAPBOX_API_KEY:
 
 Review comment:
   Having private credentials written to a file that's tracked in source control makes it likely that those credentials will be leaked unintentionally later. What do you think about leveraging `docker-compose`'s support for `.env` files (described here https://docs.docker.com/compose/environment-variables/) and providing a `.env.sample` file that can be copied to a git-ignored `.env` location by the user instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org