You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2011/08/23 00:54:29 UTC
[jira] [Created] (HADOOP-7568) SequenceFile should not print into
stdout
SequenceFile should not print into stdout
-----------------------------------------
Key: HADOOP-7568
URL: https://issues.apache.org/jira/browse/HADOOP-7568
Project: Hadoop Common
Issue Type: Bug
Reporter: Konstantin Shvachko
The following line in {{SequenceFile.Reader.initialize()}} should be removed:
{code}
System.out.println("Setting end to " + end);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101392#comment-13101392 ]
Hadoop QA commented on HADOOP-7568:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12493826/HADOOP-7568.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/152//console
This message is automatically generated.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102819#comment-13102819 ]
Hadoop QA commented on HADOOP-7568:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494068/HADOOP-7568.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/162//console
This message is automatically generated.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch, HADOOP-7568.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-7568:
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.24.0
0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thank you Plamen.
Please generate proper patches next time.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0, 0.23.0, 0.24.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103059#comment-13103059 ]
Hudson commented on HADOOP-7568:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #886 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/886/])
HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103238#comment-13103238 ]
Hudson commented on HADOOP-7568:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #816 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/816/])
HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0, 0.23.0, 0.24.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Plamen Jeliazkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Plamen Jeliazkov updated HADOOP-7568:
-------------------------------------
Attachment: HADOOP-7568.023.patch
Patch for 0.23 SequenceFile.java
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103562#comment-13103562 ]
Hudson commented on HADOOP-7568:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #792 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/792/])
HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0, 0.23.0, 0.24.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko reassigned HADOOP-7568:
-------------------------------------------
Assignee: Plamen Jeliazkov
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Plamen Jeliazkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Plamen Jeliazkov updated HADOOP-7568:
-------------------------------------
Attachment: HADOOP-7568.patch
Patch fixed.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch, HADOOP-7568.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102859#comment-13102859 ]
Harsh J commented on HADOOP-7568:
---------------------------------
Hey Plamen,
Your previous patch was fine, given that it is for 0.22 and the Hadoop QA bot isn't that intelligent (yet) to run patches off the right branch. So, fret not.
+1 to patch HADOOP-7568.patch 12/Sep/11 17:19 for branch 0.22
As a secondary request (sorry), can you also provide a patch for trunk/0.23 (should be the same). Am gonna fix my last nits (post review by Todd) on HADOOP-1381 and I'm gonna remove away this change which was added as part of it. I think it makes sense if it goes via this JIRA. Let me know if you'd like me to up that one liner instead!
Thanks!
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-7568:
----------------------------------------
Component/s: io
Affects Version/s: 0.22.0
Fix Version/s: 0.22.0
Probably was used as debug printout in HADOOP-6856.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Fix For: 0.22.0
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Plamen Jeliazkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102873#comment-13102873 ]
Plamen Jeliazkov commented on HADOOP-7568:
------------------------------------------
Thanks Harsh. :) Yeah I was wondering that was going on there. I will provide a patch for 0.23; no need to up it, you can leave it here and I will attach a patch for 0.23 asap.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Plamen Jeliazkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Plamen Jeliazkov updated HADOOP-7568:
-------------------------------------
Attachment: HADOOP-7568.patch
Patch fix.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102907#comment-13102907 ]
Hadoop QA commented on HADOOP-7568:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494093/HADOOP-7568.023.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/164//console
This message is automatically generated.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103056#comment-13103056 ]
Hudson commented on HADOOP-7568:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #874 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/874/])
HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103109#comment-13103109 ]
Hudson commented on HADOOP-7568:
--------------------------------
Integrated in Hadoop-Common-22-branch #73 (See [https://builds.apache.org/job/Hadoop-Common-22-branch/73/])
HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169930
Files :
* /hadoop/common/branches/branch-0.22/common/CHANGES.txt
* /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/io/SequenceFile.java
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0, 0.23.0, 0.24.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103071#comment-13103071 ]
Harsh J commented on HADOOP-7568:
---------------------------------
Plamen,
P.s. Just to let you in on little secrets of us ;-) here's what most of us do:
$ git checkout <branch/tag>
$ vim <file> # Or eclipse, etc. Editing++
$ ant/maven/tests etc.
$ git diff --no-prefix > PATCH.file
Or if on svn:
$ svn diff > PATCH.file # From project's root directory.
This is also covered in the HowToContribute document, and should help you avoid creating bad prefixed patches in future!
Keep up the good work :-)
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0, 0.23.0, 0.24.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Plamen Jeliazkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Plamen Jeliazkov updated HADOOP-7568:
-------------------------------------
Status: Patch Available (was: Open)
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103057#comment-13103057 ]
Hudson commented on HADOOP-7568:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #951 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/951/])
HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.023.patch, HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102156#comment-13102156 ]
Konstantin Shvachko commented on HADOOP-7568:
---------------------------------------------
Should be removed, not logged. And don't need to remove package statement.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089263#comment-13089263 ]
Harsh J commented on HADOOP-7568:
---------------------------------
Hello Konstantin,
I'd added this patch as part of HADOOP-1381 which I'll be updating for inclusion now.
Looks like this JIRA tends to 0.22.x branch, in which case it is fine to go in as another patch?
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Fix For: 0.22.0
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Plamen Jeliazkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Plamen Jeliazkov updated HADOOP-7568:
-------------------------------------
Attachment: HADOOP-7568.r2.patch
Last one, I promise.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102888#comment-13102888 ]
Harsh J commented on HADOOP-7568:
---------------------------------
Thank you Plamen! I will remove it from HADOOP-1381, and sorry for all confusions (this one had come in after its patch, which led me to my first response way up above - in retrospect, I made a mistake doing that fork request).
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7568) SequenceFile should not print into
stdout
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102857#comment-13102857 ]
Hadoop QA commented on HADOOP-7568:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494084/HADOOP-7568.r2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/163//console
This message is automatically generated.
> SequenceFile should not print into stdout
> -----------------------------------------
>
> Key: HADOOP-7568
> URL: https://issues.apache.org/jira/browse/HADOOP-7568
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Fix For: 0.22.0
>
> Attachments: HADOOP-7568.patch, HADOOP-7568.patch, HADOOP-7568.r2.patch
>
>
> The following line in {{SequenceFile.Reader.initialize()}} should be removed:
> {code}
> System.out.println("Setting end to " + end);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira