[jira] [Commented] (GEODE-5732) TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617981#comment-16617981 ] 

ASF subversion and git services commented on GEODE-5732:
--------------------------------------------------------

Commit 0adc22ecdf939586eac0020368f159fca5b6f1a9 in geode's branch refs/heads/develop from [~propeller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0adc22e ]

GEODE-5732: Remove TxCommitMessageTest

After recent move to Mockito, we found that this test doesn't fail when
we break the corresponding product code e.g. changing hasFlagsField() to
always return true should break tests but doesn't.

We verified that the test named like TxCommitMessageBC* do a better job
of checking serialization of TxCommitMessage between product versions.

Co-authored-by: Dan Smith <ds...@pivotal.io>


> TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag
> ---------------------------------------------------------------------------------
>
>                 Key: GEODE-5732
>                 URL: https://issues.apache.org/jira/browse/GEODE-5732
>             Project: Geode
>          Issue Type: Bug
>          Components: transactions
>            Reporter: Bill
>            Assignee: Bill
>            Priority: Major
>              Labels: pull-request-available, swat
>             Fix For: 1.8.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The various toDataXX and fromDataXX methods purport to test serialization/deserialization of TXCommitMessage between different product versions. Primarily, this entails looking for presence/absence of the shadow key boolean. Unfortunately, since the move to Mockito, only 1/7 of the tests actually fail when we break the product.
> The fix is to not use mocking for these tests, and to instead serialize/deserialize to/from buffers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)