Re: [PR] Parquet: Guard ordered predicates on variant/nested types in metrics row group filter [iceberg]

["nssalian (via GitHub)" <gi...@apache.org>]

nssalian commented on code in PR #17431:
URL: https://github.com/apache/iceberg/pull/17431#discussion_r3793921196


##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -1259,6 +1259,62 @@ public void testVariantFieldIn() throws IOException {
         .isTrue();
   }
 
+  @TestTemplate
+  public void testVariantFieldLt() throws IOException {
+    assumeThat(format).isEqualTo(FileFormat.PARQUET);

Review Comment:
   assumeThat(format).isEqualTo(FileFormat.PARQUET) seems redundant here and other places. 



##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -237,6 +237,13 @@ public <T> Boolean notNaN(BoundReference<T> ref) {
     public <T> Boolean lt(BoundReference<T> ref, Literal<T> lit) {
       int id = ref.fieldId();
 
+      // Leave all nested column type and variant type filters to be

Review Comment:
   This could be made into a helper something like isNestedOrVariant(int id) since it is repeated for notNull, eq, in, lt, ltEq, gt, gtEq



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org