You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2012/08/31 23:43:24 UTC
svn commit: r1379629 -
/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java
Author: pmouawad
Date: Fri Aug 31 21:43:23 2012
New Revision: 1379629
URL: http://svn.apache.org/viewvc?rev=1379629&view=rev
Log:
Don't use entrySet iteration as we only use value
Add comment on LinkedHashMap
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java?rev=1379629&r1=1379628&r2=1379629&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java Fri Aug 31 21:43:23 2012
@@ -179,6 +179,9 @@ public class RespTimeGraphVisualizer ext
private final Map<String, RespTimeGraphLineBean> seriesNames = new HashMap<String, RespTimeGraphLineBean>();
+ /**
+ * We want to retain insertion order, so LinkedHashMap is necessary
+ */
private final Map<String, Map<Integer, Long>> pList = new LinkedHashMap<String, Map<Integer, Long>>();
private int durationTest = 0;
@@ -240,6 +243,7 @@ public class RespTimeGraphVisualizer ext
}
subList.put(Integer.valueOf(startTimeInterval), Long.valueOf(respTime));
} else {
+ // We want to retain insertion order, so LinkedHashMap is necessary
Map<Integer, Long> newSubList = new LinkedHashMap<Integer, Long>();
newSubList.put(Integer.valueOf(startTimeInterval), Long.valueOf(sampleResult.getTime()));
pList.put(sampleLabel, newSubList);
@@ -311,9 +315,7 @@ public class RespTimeGraphVisualizer ext
double nanBegin = 0;
List<Double> nanList = new ArrayList<Double>();
int s = 0;
- for (Map.Entry<String, Map<Integer, Long>> pointEntry : pList.entrySet()) {
- Map<Integer, Long> subList = pointEntry.getValue();
-
+ for (Map<Integer, Long> subList : pList.values()) {
int idx = 0;
while (idx < durationTest) {
int keyShift = minStartTime + idx;