You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2013/06/27 15:12:20 UTC

[jira] [Commented] (WICKET-5257) Make css class strings used in the framework configurable

    [ https://issues.apache.org/jira/browse/WICKET-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694693#comment-13694693 ] 

Martin Grigorov commented on WICKET-5257:
-----------------------------------------

The change is done in branch "5257-css-settings".
Please review.

Few CSS classes from the new Tree are not in the new ICssSettings. I'm not sure whether we should add them because the Tree comes with its .css files and this will broke its UI.
                
> Make css class strings used in the framework configurable
> ---------------------------------------------------------
>
>                 Key: WICKET-5257
>                 URL: https://issues.apache.org/jira/browse/WICKET-5257
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.0.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>
> From the roadmap document for Wicket 7:
> In a few places in core we have hardcoded css strings like wicket_orderUp and classes used inside the feedback panel - these should be made into application settings so they can be configured to conform to the application's css infrastructure.
> Once we extract wicket_orderUp we should get rid of cssprovider and defaultcssprovider classes.
> getApplication().getCssSettings().setSortOrderDownClass("sort-order-down");

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira