You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 05:55:52 UTC

[I] Refactor HoodieWriteConfig to make sure we have a uniform and better way to access config value [hudi]

hudi-bot opened a new issue, #15472:
URL: https://github.com/apache/hudi/issues/15472

   I feel like this class is a hodgepodge and is ballooning. It does not demonstrate the benefits of configuration separation that a pluggable architecture should bring. 
   
   if we keep wrap config.getString(ConfigKey) with a getter method such as config.get{$ConfigKey}() in HoodieWriteConfig, basically we need to include almost every configKey in every config(such as HoodieClusteringConfig,HoodieHBaseIndexConfig,HoodieIndexConfig,HoodieStorageConfig and etc) to HoodieWriteConfig
   
   for the consistent manner and clean code purpose, I think we should inline all the getter methods that have no logic  
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-4964
   - Type: Improvement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor HoodieWriteConfig to make sure we have a uniform and better way to access config value [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on issue #15472:
URL: https://github.com/apache/hudi/issues/15472#issuecomment-3630224978

   ### Linked PR(s)
   
   - https://github.com/apache/hudi/pull/6850


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org