[GitHub] [incubator-nuttx] patacongo edited a comment on issue #503: Don't actually send a signal with signo 0

[GitBox <gi...@apache.org>]

patacongo edited a comment on issue #503: Don't actually send a signal with signo 0
URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596532129
 
 
   Basically, your change only works if HAVE_GROUP_MEMBERS is not defined.  If that is defined, then calling kill() or sigqueue() will go a different path:
   
   kill->nxsig_kill->nxsig_dispatch->group_signal
   
   You change also does not handle multi-threaded task groups.  The task ID may no longer be valid, but the task group may persist.  In this case, a different pthread member of the group will receive the signal.
   
   That can be fixed by moving the null signal check to lines 528 and 546

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services