You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/03 11:16:40 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #10403: Refactor DataprocCreateCluster operator to use simpler interface

turbaszek commented on a change in pull request #10403:
URL: https://github.com/apache/airflow/pull/10403#discussion_r482900283



##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -467,20 +454,15 @@ class DataprocCreateClusterOperator(BaseOperator):
     :type impersonation_chain: Union[str, Sequence[str]]
     """
 
-    template_fields = (
-        'project_id',
-        'region',
-        'cluster',
-        'impersonation_chain',
-    )
-
     @apply_defaults
     def __init__(  # pylint: disable=too-many-arguments
         self,
         *,
+        cluster_name: str,

Review comment:
       This backward compatible with 1.10.X:
   https://github.com/apache/airflow/blob/827a717fecc675b4d58fa202be003dee8e423632/airflow/contrib/operators/dataproc_operator.py#L192-L193




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org