[GitHub] sven-lange-last commented on a change in pull request #4176: additional container factory dns configuration

[GitBox <gi...@apache.org>]

sven-lange-last commented on a change in pull request #4176: additional container factory dns configuration
URL: https://github.com/apache/incubator-openwhisk/pull/4176#discussion_r241804108
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainer.scala
 ##########
 @@ -93,6 +95,9 @@ object DockerContainer {
       network) ++
       environmentArgs ++
       dnsServers.flatMap(d => Seq("--dns", d)) ++
+      dnsSearch.flatMap(d => Seq("--dns-search", d)) ++
+      // NOTE: --dns-option on modern versions of docker, but is --dns-opt on docker 1.12
+      dnsOptions.flatMap(d => Seq("--dns-opt", d)) ++
 
 Review comment:
   We need to be very careful here. While I understand that OW officially supports Docker 1.12, I know that higher Docker versions are used as well.
   
   I'm not in favour of using the `--dns-opt` option here although we already know it won't work in higher versions. This is weak point that will definitely break in future or when using a higher Docker version today.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services