You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Henry Saputra <hs...@apache.org> on 2011/07/11 09:02:12 UTC
Review Request: SHINDIG-1556 - Set DefaultSecurityTokenCodec for common
container example to fix OAuth gadget error with common container sample
page.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1067/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Remove the TestSecurityTokenCodec for common container to make the OAuth gadget works by allowing DefaultSecurityTokenCodec to create the right st.
Diffs
-----
trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1145041
trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerAuthGuiceModule.java 1145041
trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerSecurityTokenCodec.java 1145041
trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/TestSecurityTokenCodec.java 1145041
trunk/java/server/src/main/webapp/WEB-INF/web.xml 1145041
Diff: https://reviews.apache.org/r/1067/diff
Testing
-------
pass unit test and run gadgets in common container sample page.
Thanks,
Henry
Re: Review Request: SHINDIG-1556 - Set DefaultSecurityTokenCodec for common
container example to fix OAuth gadget error with common container sample
page.
Posted by Henry Saputra <hs...@apache.org>.
> On 2011-07-11 15:46:53, Paul Lindner wrote:
> > trunk/content/samplecontainer/examples/commoncontainer/assembler.js, line 31
> > <https://reviews.apache.org/r/1067/diff/1/?file=22237#file22237line31>
> >
> > Optional: add a comment about how this requires use of the default security token config?
Good idea, will absolutely do.
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1067/#review1023
-----------------------------------------------------------
On 2011-07-11 07:02:12, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1067/
> -----------------------------------------------------------
>
> (Updated 2011-07-11 07:02:12)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Remove the TestSecurityTokenCodec for common container to make the OAuth gadget works by allowing DefaultSecurityTokenCodec to create the right st.
>
>
> Diffs
> -----
>
> trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerAuthGuiceModule.java 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerSecurityTokenCodec.java 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/TestSecurityTokenCodec.java 1145041
> trunk/java/server/src/main/webapp/WEB-INF/web.xml 1145041
>
> Diff: https://reviews.apache.org/r/1067/diff
>
>
> Testing
> -------
>
> pass unit test and run gadgets in common container sample page.
>
>
> Thanks,
>
> Henry
>
>
Re: Review Request: SHINDIG-1556 - Set DefaultSecurityTokenCodec for common
container example to fix OAuth gadget error with common container sample
page.
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1067/#review1023
-----------------------------------------------------------
trunk/content/samplecontainer/examples/commoncontainer/assembler.js
<https://reviews.apache.org/r/1067/#comment2103>
Optional: add a comment about how this requires use of the default security token config?
- Paul
On 2011-07-11 07:02:12, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1067/
> -----------------------------------------------------------
>
> (Updated 2011-07-11 07:02:12)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Remove the TestSecurityTokenCodec for common container to make the OAuth gadget works by allowing DefaultSecurityTokenCodec to create the right st.
>
>
> Diffs
> -----
>
> trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerAuthGuiceModule.java 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerSecurityTokenCodec.java 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/TestSecurityTokenCodec.java 1145041
> trunk/java/server/src/main/webapp/WEB-INF/web.xml 1145041
>
> Diff: https://reviews.apache.org/r/1067/diff
>
>
> Testing
> -------
>
> pass unit test and run gadgets in common container sample page.
>
>
> Thanks,
>
> Henry
>
>
Re: Review Request: SHINDIG-1556 - Set DefaultSecurityTokenCodec for common
container example to fix OAuth gadget error with common container sample
page.
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1067/#review1024
-----------------------------------------------------------
Ship it!
I always like removing excess code wherever possible.
- Paul
On 2011-07-11 07:02:12, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1067/
> -----------------------------------------------------------
>
> (Updated 2011-07-11 07:02:12)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Remove the TestSecurityTokenCodec for common container to make the OAuth gadget works by allowing DefaultSecurityTokenCodec to create the right st.
>
>
> Diffs
> -----
>
> trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerAuthGuiceModule.java 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerSecurityTokenCodec.java 1145041
> trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/TestSecurityTokenCodec.java 1145041
> trunk/java/server/src/main/webapp/WEB-INF/web.xml 1145041
>
> Diff: https://reviews.apache.org/r/1067/diff
>
>
> Testing
> -------
>
> pass unit test and run gadgets in common container sample page.
>
>
> Thanks,
>
> Henry
>
>