You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ib...@apache.org on 2020/09/17 16:45:01 UTC
[beam] branch master updated: [BEAM-10915] Fix error hint for
AVG(INT64).
This is an automated email from the ASF dual-hosted git repository.
ibzib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new e100492 [BEAM-10915] Fix error hint for AVG(INT64).
new 23bff89 Merge pull request #12859 from ibzib/BEAM-10915
e100492 is described below
commit e1004922a2d453a5efa829d770cc21b94e80867e
Author: Kyle Weaver <kc...@google.com>
AuthorDate: Wed Sep 16 17:29:42 2020 -0700
[BEAM-10915] Fix error hint for AVG(INT64).
---
.../sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java | 2 +-
.../apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java b/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java
index 9173bf6..e1f6faf 100644
--- a/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java
+++ b/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java
@@ -49,7 +49,7 @@ import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Immutabl
/** Converts aggregate calls. */
class AggregateScanConverter extends RelConverter<ResolvedAggregateScan> {
private static final String AVG_ILLEGAL_LONG_INPUT_TYPE =
- "AVG(LONG) is not supported. You might want to use AVG(CAST(expression AS DOUBLE).";
+ "AVG(INT64) is not supported. You might want to use AVG(CAST(expression AS FLOAT64).";
AggregateScanConverter(ConversionContext context) {
super(context);
diff --git a/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java b/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
index a802e57..8417382 100644
--- a/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
+++ b/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
@@ -4301,7 +4301,7 @@ public class ZetaSqlDialectSpecTest extends ZetaSqlTestBase {
ZetaSQLQueryPlanner zetaSQLQueryPlanner = new ZetaSQLQueryPlanner(config);
thrown.expect(RuntimeException.class);
thrown.expectMessage(
- "AVG(LONG) is not supported. You might want to use AVG(CAST(expression AS DOUBLE).");
+ "AVG(INT64) is not supported. You might want to use AVG(CAST(expression AS FLOAT64).");
zetaSQLQueryPlanner.convertToBeamRel(sql);
}