You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "JinHeap (via GitHub)" <gi...@apache.org> on 2024/05/30 07:20:27 UTC
[PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]
JinHeap opened a new pull request, #511:
URL: https://github.com/apache/mina-sshd/pull/511
Addresses https://github.com/apache/mina-sshd/issues/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]
Posted by "JinHeap (via GitHub)" <gi...@apache.org>.
JinHeap commented on PR #511:
URL: https://github.com/apache/mina-sshd/pull/511#issuecomment-2141078742
thanks. then if need me do something, please tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf closed pull request #511: Fix mina full class name in BuiltinIoServiceFactoryFactories
URL: https://github.com/apache/mina-sshd/pull/511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #511:
URL: https://github.com/apache/mina-sshd/pull/511#issuecomment-2140908858
Thanks. The change is good, but now that this is fixed `DefaultIoServiceFactoryFactoryTest` hangs for MINA during disposal of the partially set up (with mocks) `MinaServiceFactory`. Previously it just skipped the non-existing class.
Also, `BuiltinIoServiceFactoryFactoriesTest` should have a test that fails if one of the enum constants has a wrong class name. I.e., a test that would have uncovered the original problem (wrong string).
I'll see if I can amend this commit to fix these test issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #511:
URL: https://github.com/apache/mina-sshd/pull/511#issuecomment-2142664561
Merged as commit 82e0ed1f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org