[Suggestion] Add maven wrapper

[ht...@gmail.com, ht...@gmail.com]

hey team,

I suggest adding maven wrapper to Dubbo project. (https://github.com/takari/maven-wrapper)

maven wrapper can help us to use same maven version to avoid some unexpected issue. 
maven wrapper also helps the user who doesn't install maven in their own machine to easily use maven.

I think many projects using maven wrapper. below are some example:
https://github.com/netty/netty/tree/4.1/.mvn/wrapper
https://github.com/spring-projects/spring-boot/tree/master/.mvn/wrapper

Regards，
Yunkun

Re: [Suggestion] Add maven wrapper

[jun liu <ke...@gmail.com>]

> Just be aware you can’t put maven-wrapper.jar in a source release as it’s compile code.

Thanks for the reminding. I think we can add rules to exclude the maven-wrapper.jar from source release.

Best regards,
Jun

> On 1 Jun 2018, at 4:21 PM, Justin Mclean <ju...@classsoftware.com> wrote:
> 
> Hi,
> 
> Just be aware you can’t put maven-wrapper.jar in a source release as it’s compile code.
> 
> Thanks,
> Justin

Re: [Suggestion] Add maven wrapper

[Justin Mclean <ju...@classsoftware.com>]

Hi,

Just be aware you can’t put maven-wrapper.jar in a source release as it’s compile code.

Thanks,
Justin

Re: [Suggestion] Add maven wrapper

[jun liu <ke...@gmail.com>]

+1, here is an open issue asking for this feature:
https://github.com/apache/incubator-dubbo/issues/553

Best regards,
Jun

> On 1 Jun 2018, at 4:09 PM, htynkn@gmail.com wrote:
> 
> hey team,
> 
> I suggest adding maven wrapper to Dubbo project. (https://github.com/takari/maven-wrapper)
> 
> maven wrapper can help us to use same maven version to avoid some unexpected issue. 
> maven wrapper also helps the user who doesn't install maven in their own machine to easily use maven.
> 
> I think many projects using maven wrapper. below are some example:
> https://github.com/netty/netty/tree/4.1/.mvn/wrapper
> https://github.com/spring-projects/spring-boot/tree/master/.mvn/wrapper
> 
> Regards，
> Yunkun
>