You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/07/30 13:20:23 UTC
[GitHub] [hbase] petersomogyi opened a new pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
petersomogyi opened a new pull request #3547:
URL: https://github.com/apache/hbase/pull/3547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-889918617
For branch-2 only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-890915446
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 36s | Docker mode activated. |
| -0 :warning: | yetus | 0m 9s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 39s | branch-2 passed |
| +1 :green_heart: | compile | 0m 22s | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 41s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 15s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 23s | the patch passed |
| +1 :green_heart: | compile | 0m 27s | the patch passed |
| +1 :green_heart: | javac | 0m 27s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 49s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 17s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 24s | hbase-shaded-testing-util in the patch passed. |
| | | 33m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3547 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 8bfafa4dc796 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / aa3b07f6bb |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/testReport/ |
| Max. process+thread count | 66 (vs. ulimit of 12500) |
| modules | C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi merged pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
petersomogyi merged pull request #3547:
URL: https://github.com/apache/hbase/pull/3547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-890920341
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 57s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 23s | branch-2 passed |
| +1 :green_heart: | compile | 0m 27s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 55s | the patch passed |
| +1 :green_heart: | compile | 0m 24s | the patch passed |
| +1 :green_heart: | javac | 0m 24s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 18m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 43m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3547 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile |
| uname | Linux bd9472167d69 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / aa3b07f6bb |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 69 (vs. ulimit of 12500) |
| modules | C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-890079445
Should be fine to add the exclusions to all branches, or not, I have no strong opinion either way. Better to be consistent across all POMs in all branches if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-890937207
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 44s | Docker mode activated. |
| -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 57s | branch-2 passed |
| +1 :green_heart: | compile | 0m 30s | branch-2 passed |
| +1 :green_heart: | shadedjars | 9m 31s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 15s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 29s | the patch passed |
| +1 :green_heart: | compile | 0m 25s | the patch passed |
| +1 :green_heart: | javac | 0m 25s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 34s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 17s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 27s | hbase-shaded-testing-util in the patch passed. |
| | | 36m 43s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3547 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f19ca6d03ba7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / aa3b07f6bb |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/testReport/ |
| Max. process+thread count | 85 (vs. ulimit of 12500) |
| modules | C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-890079445
Should be fine to add the exclusions to all branches, or not, I have no strong opinion either way. Better to be consistent across all POMs in all branches is the small preference I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
petersomogyi commented on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-890849506
> Should be fine to add the exclusions to all branches, or not, I have no strong opinion either way. Better to be consistent across all POMs in all branches if possible.
This pom.xml is already different on the branches. The `hadoop-mapreduce-client-app` dependency does not require any exclusions on master branch while the shading rule also differs on branch-2.3. Based on this I'd prefer to commit this to branch-2 and branch-2.4 only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Posted by GitBox <gi...@apache.org>.
petersomogyi commented on pull request #3547:
URL: https://github.com/apache/hbase/pull/3547#issuecomment-889920542
> For branch-2 only?
Yes. TestShadedHBaseTestingUtility passes on master and branch-2.3. Only fails on branch-2 and branch-2.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org