You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "chrajeshbabu (via GitHub)" <gi...@apache.org> on 2024/10/11 11:28:09 UTC

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars [pinot]

chrajeshbabu commented on code in PR #14015:
URL: https://github.com/apache/pinot/pull/14015#discussion_r1796821843


##########
pinot-common/pom.xml:
##########
@@ -100,22 +100,31 @@
       <!-- "Plugs in" the Calcite's Parser.jj with the variables present in config.fmpp. These contain the custom rules
            as well as the class to which the custom implementation will get generated -->
       <plugin>
-        <groupId>com.googlecode.fmpp-maven-plugin</groupId>
-        <artifactId>fmpp-maven-plugin</artifactId>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-antrun-plugin</artifactId>
         <executions>
           <execution>
-            <id>generate-fmpp-sources</id>
             <phase>generate-sources</phase>
-            <goals>
-              <goal>generate</goal>
-            </goals>
             <configuration>
-              <cfgFile>${project.build.directory}/codegen/config.fmpp</cfgFile>
-              <outputDirectory>${project.build.directory}/generated-sources</outputDirectory>
-              <templateDirectory>${project.build.directory}/codegen/templates</templateDirectory>
+              <target name="generate-code">
+                <taskdef name="fmpp" classname="fmpp.tools.AntTask" classpathref="maven.compile.classpath"/>
+                <fmpp configuration="${project.build.directory}/codegen/config.fmpp"
+                    sourceRoot="${project.build.directory}/codegen/templates"
+                    outputRoot="${project.build.directory}/generated-sources"/>
+              </target>
             </configuration>
+            <goals>
+              <goal>run</goal>
+            </goals>
           </execution>
         </executions>
+        <dependencies>
+          <dependency>
+            <groupId>net.sourceforge.fmpp</groupId>
+            <artifactId>fmpp</artifactId>
+            <version>${fmpp.version}</version>

Review Comment:
   Rebased PR by fixing the conflicts with latest code. Added the dependency at the root pom as agreed and follow the similar dependency management.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org