You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/05 13:13:57 UTC
(commons-collections) branch master updated: Make package private class final
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
The following commit(s) were added to refs/heads/master by this push:
new 07967afd4 Make package private class final
07967afd4 is described below
commit 07967afd4bbdb3f7bb8b3c584aba26ab6afd0b8a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 5 08:13:52 2023 -0500
Make package private class final
---
.../org/apache/commons/collections4/ArrayUtils.java | 2 +-
.../commons/collections4/bag/SynchronizedBag.java | 2 +-
.../commons/collections4/bidimap/TreeBidiMap.java | 18 +++++++++---------
.../commons/collections4/functors/FunctorUtils.java | 2 +-
.../collections4/multimap/AbstractMultiValuedMap.java | 4 ++--
.../commons/collections4/list/SetUniqueListTest.java | 2 +-
.../commons/collections4/map/EmptyMapMutator.java | 2 +-
.../commons/collections4/set/EmptySetMutator.java | 2 +-
8 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/main/java/org/apache/commons/collections4/ArrayUtils.java b/src/main/java/org/apache/commons/collections4/ArrayUtils.java
index 8f2871ea6..61cbb4821 100644
--- a/src/main/java/org/apache/commons/collections4/ArrayUtils.java
+++ b/src/main/java/org/apache/commons/collections4/ArrayUtils.java
@@ -35,7 +35,7 @@ package org.apache.commons.collections4;
*
* @since 4.2 (Copied from Apache Commons Lang.)
*/
-class ArrayUtils {
+final class ArrayUtils {
/**
diff --git a/src/main/java/org/apache/commons/collections4/bag/SynchronizedBag.java b/src/main/java/org/apache/commons/collections4/bag/SynchronizedBag.java
index ba469ccaa..3420f4ddf 100644
--- a/src/main/java/org/apache/commons/collections4/bag/SynchronizedBag.java
+++ b/src/main/java/org/apache/commons/collections4/bag/SynchronizedBag.java
@@ -133,7 +133,7 @@ public class SynchronizedBag<E> extends SynchronizedCollection<E> implements Bag
/**
* Synchronized Set for the Bag class.
*/
- class SynchronizedBagSet extends SynchronizedCollection<E> implements Set<E> {
+ final class SynchronizedBagSet extends SynchronizedCollection<E> implements Set<E> {
/** Serialization version */
private static final long serialVersionUID = 2990565892366827855L;
diff --git a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
index 0eb3a8adf..c6e46fe5e 100644
--- a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
+++ b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
@@ -1496,7 +1496,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
}
}
- class KeyView extends AbstractView<K> {
+ final class KeyView extends AbstractView<K> {
/**
* Creates a new TreeBidiMap.KeyView.
@@ -1523,7 +1523,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
}
- class ValueView extends AbstractView<V> {
+ final class ValueView extends AbstractView<V> {
/**
* Creates a new TreeBidiMap.ValueView.
@@ -1553,7 +1553,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
/**
* A view of this map.
*/
- class EntryView extends AbstractView<Map.Entry<K, V>> {
+ final class EntryView extends AbstractView<Map.Entry<K, V>> {
EntryView() {
super(KEY);
@@ -1594,7 +1594,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
/**
* A view of this map.
*/
- class InverseEntryView extends AbstractView<Map.Entry<V, K>> {
+ final class InverseEntryView extends AbstractView<Map.Entry<V, K>> {
InverseEntryView() {
super(VALUE);
@@ -1718,7 +1718,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
/**
* An iterator over the map.
*/
- class ViewMapIterator extends AbstractViewIterator implements OrderedMapIterator<K, V> {
+ final class ViewMapIterator extends AbstractViewIterator implements OrderedMapIterator<K, V> {
/**
* Constructor.
@@ -1764,7 +1764,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
/**
* An iterator over the map.
*/
- class InverseViewMapIterator extends AbstractViewIterator implements OrderedMapIterator<V, K> {
+ final class InverseViewMapIterator extends AbstractViewIterator implements OrderedMapIterator<V, K> {
/**
* Creates a new TreeBidiMap.InverseViewMapIterator.
@@ -1810,7 +1810,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
/**
* An iterator over the map entries.
*/
- class ViewMapEntryIterator extends AbstractViewIterator implements OrderedIterator<Map.Entry<K, V>> {
+ final class ViewMapEntryIterator extends AbstractViewIterator implements OrderedIterator<Map.Entry<K, V>> {
/**
* Constructor.
@@ -1833,7 +1833,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
/**
* An iterator over the inverse map entries.
*/
- class InverseViewMapEntryIterator extends AbstractViewIterator implements OrderedIterator<Map.Entry<V, K>> {
+ final class InverseViewMapEntryIterator extends AbstractViewIterator implements OrderedIterator<Map.Entry<V, K>> {
/**
* Constructor.
@@ -2083,7 +2083,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
/**
* The inverse map implementation.
*/
- class Inverse implements OrderedBidiMap<V, K> {
+ final class Inverse implements OrderedBidiMap<V, K> {
/** Store the keySet once created. */
private Set<V> inverseKeySet;
diff --git a/src/main/java/org/apache/commons/collections4/functors/FunctorUtils.java b/src/main/java/org/apache/commons/collections4/functors/FunctorUtils.java
index 0b1998dbe..251edfa6c 100644
--- a/src/main/java/org/apache/commons/collections4/functors/FunctorUtils.java
+++ b/src/main/java/org/apache/commons/collections4/functors/FunctorUtils.java
@@ -28,7 +28,7 @@ import org.apache.commons.collections4.Transformer;
*
* @since 3.0
*/
-class FunctorUtils {
+final class FunctorUtils {
/**
* Restricted constructor.
diff --git a/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java b/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java
index 10f101d5f..215e1ddcd 100644
--- a/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java
+++ b/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java
@@ -828,7 +828,7 @@ public abstract class AbstractMultiValuedMap<K, V> implements MultiValuedMap<K,
AbstractMultiValuedMap.this.clear();
}
- class AsMapEntrySet extends AbstractSet<Map.Entry<K, Collection<V>>> {
+ final class AsMapEntrySet extends AbstractSet<Map.Entry<K, Collection<V>>> {
@Override
public Iterator<Map.Entry<K, Collection<V>>> iterator() {
@@ -864,7 +864,7 @@ public abstract class AbstractMultiValuedMap<K, V> implements MultiValuedMap<K,
/**
* EntrySet iterator for the asMap view.
*/
- class AsMapEntrySetIterator extends AbstractIteratorDecorator<Map.Entry<K, Collection<V>>> {
+ final class AsMapEntrySetIterator extends AbstractIteratorDecorator<Map.Entry<K, Collection<V>>> {
AsMapEntrySetIterator(final Iterator<Map.Entry<K, Collection<V>>> iterator) {
super(iterator);
diff --git a/src/test/java/org/apache/commons/collections4/list/SetUniqueListTest.java b/src/test/java/org/apache/commons/collections4/list/SetUniqueListTest.java
index 3da6f6d72..ee22daf49 100644
--- a/src/test/java/org/apache/commons/collections4/list/SetUniqueListTest.java
+++ b/src/test/java/org/apache/commons/collections4/list/SetUniqueListTest.java
@@ -42,7 +42,7 @@ import org.junit.jupiter.api.Test;
*/
public class SetUniqueListTest<E> extends AbstractListTest<E> {
- class SetUniqueList307 extends SetUniqueList<E> {
+ final class SetUniqueList307 extends SetUniqueList<E> {
/**
* Generated serial version ID.
*/
diff --git a/src/test/java/org/apache/commons/collections4/map/EmptyMapMutator.java b/src/test/java/org/apache/commons/collections4/map/EmptyMapMutator.java
index 57955ec51..04418ea4a 100644
--- a/src/test/java/org/apache/commons/collections4/map/EmptyMapMutator.java
+++ b/src/test/java/org/apache/commons/collections4/map/EmptyMapMutator.java
@@ -24,7 +24,7 @@ import java.util.Map;
* the class has to be separate of TestCompositeMap, else the test
* class also has to be serialized.
*/
-class EmptyMapMutator<K, V> implements CompositeMap.MapMutator<K, V> {
+final class EmptyMapMutator<K, V> implements CompositeMap.MapMutator<K, V> {
/** Serialization version */
private static final long serialVersionUID = -2729718980002476794L;
diff --git a/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java b/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java
index ff790a15b..4c531f465 100644
--- a/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java
+++ b/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java
@@ -25,7 +25,7 @@ import java.util.Set;
* the class has to be separate of CompositeSetTest, else the test
* class also has to be serialized.
*/
-class EmptySetMutator<E> implements CompositeSet.SetMutator<E> {
+final class EmptySetMutator<E> implements CompositeSet.SetMutator<E> {
/** Serialization version */
private static final long serialVersionUID = 5321193666420238910L;