You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/10/05 17:48:11 UTC
[GitHub] [orc] omalley commented on a change in pull request #548: ORC-670. RecordReaderImpl.findColumns should respect orc.schema.evolution.case.sensitive
omalley commented on a change in pull request #548:
URL: https://github.com/apache/orc/pull/548#discussion_r499766335
##########
File path: java/core/src/java/org/apache/orc/TypeDescription.java
##########
@@ -818,8 +818,12 @@ public TypeDescription findSubtype(int goal) {
* @return the subtype
*/
public TypeDescription findSubtype(String columnName) {
+ return findSubtype(columnName, true);
+ }
+
+ public TypeDescription findSubtype(String columnName, Boolean isSchemaEvolutionCaseAware) {
Review comment:
This should be boolean.
##########
File path: java/core/src/java/org/apache/orc/impl/ParserUtils.java
##########
@@ -246,6 +246,12 @@ public static TypeDescription parseType(ParserUtils.StringPosition source) {
public static TypeDescription findSubtype(TypeDescription schema,
ParserUtils.StringPosition source) {
+ return findSubtype(schema, source, true);
+ }
+
+ public static TypeDescription findSubtype(TypeDescription schema,
+ ParserUtils.StringPosition source,
+ Boolean isSchemaEvolutionCaseAware) {
Review comment:
This should be boolean instead of Boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org