[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

["Paul Rogers (Code Review)" <ge...@cloudera.org>]

Paul Rogers has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12265 )

Change subject: IMPALA-8106: Cleanup of literal expression nodes
......................................................................

IMPALA-8106: Cleanup of literal expression nodes

IMPALA-7902 cleaned up numeric literals to simplify cast logic, to
avoid the need to analyze a literal, and so on. This patch does
the same for the other literal expressions which, as a whole, need
less work than the numeric literal did. Specifically:

* Remove the need to analyze any literal expression.
* Clean up the way that code creates and analyzes literals.
* Streamlined code that creates a literal outside of an AST.

This work is part of the ongoing effort to merge expression
rewrites into a single-pass analysis phase in order to more cleanly
introduce additional rewrite rules.

Tests:

* Reran all FE tests and updated several as needed.
* Added a set of literal expression tests.
* Updated PlannerTests to show the type of NULL values.

Change-Id: I740f877964d5bc677fef98f1ccfa5be32cc8f7ac
---
M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java
M fe/src/main/java/org/apache/impala/analysis/BoolLiteral.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java
M fe/src/main/java/org/apache/impala/analysis/NullLiteral.java
M fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java
M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java
M fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/Type.java
M fe/src/main/java/org/apache/impala/common/InvalidValueException.java
M fe/src/main/java/org/apache/impala/common/SqlCastException.java
M fe/src/test/java/org/apache/impala/analysis/LiteralExprTest.java
M fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering-disabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test
M testdata/workloads/functional-planner/queries/PlannerTest/partition-pruning.test
M testdata/workloads/functional-query/queries/QueryTest/chars-tmp-tables.test
20 files changed, 617 insertions(+), 133 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/12265/10
-- 
To view, visit http://gerrit.cloudera.org:8080/12265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I740f877964d5bc677fef98f1ccfa5be32cc8f7ac
Gerrit-Change-Number: 12265
Gerrit-PatchSet: 10
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>